samples: gpio: remove redundant application #21117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality of samples/drivers/gpio sample application duplicates already existing code in samples/basic/blinky and samples/basic/button. This commit removes the gpio sample application. Signed-off-by: Piotr Mienkowski <[email protected]>
mnkp
requested review from
MaureenHelm,
carlescufi,
dbkinder,
erwango,
galak,
nashif and
pabigot
nashif
approved these changes
Dec 3, 2019
pabigot
approved these changes
Dec 3, 2019
erwango
approved these changes
Dec 3, 2019
dbkinder
approved these changes
Dec 4, 2019
Contributor
dbkinder
left a comment
dbkinder
left a comment
There was a problem hiding this comment.
LGTM (since there was no documentation for this sample as well :)
MaureenHelm
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of
samples/drivers/gpiosample application duplicatesalready existing code in
samples/basic/blinkyandsamples/basic/button.This commit removes the gpio sample application.