libc: newlib: Remove gnuarmemb restriction on newlib nano variant #21098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEWLIB_LIBC_NANO was defined only for gnuarmemb toolchain because Zephyr SDK did not support the newlib nano variant (as defined by nano.specs) due to the inherent limitations of crosstool-ng, which is used to build the toolchains. Since crosstool-ng/crosstool-ng#1279 added support for the nano C/C++ runtime library variant and this change was introduced to the Zephyr SDK through zephyrproject-rtos#153, it is no longer necessary to restrict the newlib nano variant to gnuarmemb toolchain only. Signed-off-by: Stephanos Ioannidis <[email protected]>
|
LGTM, just depends on when we move to SDK 0.11.0. |
galak
approved these changes
Dec 2, 2019
|
this is not obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEWLIB_LIBC_NANO was defined only for gnuarmemb toolchain because
Zephyr SDK did not support the newlib nano variant (as defined by
nano.specs) due to the inherent limitations of crosstool-ng, which is
used to build the toolchains.
Since crosstool-ng/crosstool-ng#1279 added support for the nano C/C++
runtime library variant and this change was introduced to the Zephyr
SDK through #153, it is no longer necessary to
restrict the newlib nano variant to gnuarmemb toolchain only.
Signed-off-by: Stephanos Ioannidis [email protected]
NOTE: This PR should be merged after zephyrproject-rtos/sdk-ng#153 is merged and available in a Zephyr SDK release.