-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[TOPIC-GPIO] drivers: hci: spi: update to new GPIO API #21062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
carlescufi
merged 1 commit into
zephyrproject-rtos:topic-gpio
from
erwango:gpio_hci_spi
Dec 19, 2019
Merged
[TOPIC-GPIO] drivers: hci: spi: update to new GPIO API #21062
carlescufi
merged 1 commit into
zephyrproject-rtos:topic-gpio
from
erwango:gpio_hci_spi
Dec 19, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhedberg
approved these changes
Nov 28, 2019
mnkp
requested changes
Dec 8, 2019
joerchan
approved these changes
Dec 8, 2019
Member
Author
|
@mnkp, updated, thanks for the review |
Member
Author
|
@mnkp, updated |
mnkp
reviewed
Dec 10, 2019
Member
mnkp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
6f0ed1f to
b22e7b4
Compare
Member
Author
|
@mnkp, updated |
mnkp
reviewed
Dec 11, 2019
mnkp
approved these changes
Dec 11, 2019
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
14902b8 to
1c752d3
Compare
Update bluetooth hcp spi driver to new GPIO API. Following changes have been done: - Use new gpio api functions - Get reset, irq and cs flags from dt defines - Define reset pin as active low and invert set/unset logic. Tested on disco_l475_iot1 and 96b_carbon. Signed-off-by: Erwan Gouriou <[email protected]>
1c752d3 to
9ca9947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bluetooth hcp spi driver to new GPIO API.
Tested on disco_l475_iot1 and 96b_carbon.
Signed-off-by: Erwan Gouriou [email protected]