Skip to content

Conversation

@erwango
Copy link
Member

@erwango erwango commented Nov 28, 2019

Update bluetooth hcp spi driver to new GPIO API.

Tested on disco_l475_iot1 and 96b_carbon.

Signed-off-by: Erwan Gouriou [email protected]

@erwango
Copy link
Member Author

erwango commented Dec 9, 2019

@mnkp, updated, thanks for the review

@joerchan joerchan requested a review from mnkp December 9, 2019 15:54
@erwango
Copy link
Member Author

erwango commented Dec 10, 2019

@mnkp, updated

Copy link
Member

@mnkp mnkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

@erwango
Copy link
Member Author

erwango commented Dec 11, 2019

@mnkp, updated

@zephyrbot
Copy link

zephyrbot commented Dec 11, 2019

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Update bluetooth hcp spi driver to new GPIO API.
Following changes have been done:
- Use new gpio api functions
- Get reset, irq and cs flags from dt defines
- Define reset pin as active low and invert set/unset logic.

Tested on disco_l475_iot1 and 96b_carbon.

Signed-off-by: Erwan Gouriou <[email protected]>
@carlescufi carlescufi merged commit 2fa2f8a into zephyrproject-rtos:topic-gpio Dec 19, 2019
@erwango erwango requested a review from carlescufi January 23, 2020 14:15
@erwango erwango deleted the gpio_hci_spi branch January 27, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants