[TOPIC-GPIO] update CAN #20944
Merged
[TOPIC-GPIO] update CAN #20944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karstenkoenig
requested review from
alexanderwachter,
mnkp,
nixward and
pabigot
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
karstenkoenig
force-pushed
the
topic-gpio-can
branch
from
6ef3d4d to
104700c
Compare
Mark the INT signal to be active low and use the new functions to get gpio state and configure the gpio interrupt flanks. Signed-off-by: Karsten Koenig <[email protected]>
Switched from deprecated gpio_pin_write to gpio_pin_set and also add the LED GPIO flags to the gpio configuration. Signed-off-by: Karsten Koenig <[email protected]>
karstenkoenig
force-pushed
the
topic-gpio-can
branch
from
104700c to
b6e136d
Compare
mnkp
approved these changes
Nov 25, 2019
alexanderwachter
approved these changes
Nov 26, 2019
nixward
suggested changes
Nov 26, 2019
nixward
approved these changes
Nov 26, 2019
Member
|
@carlescufi updatet the state in #20017 to Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch both the CAN sample with it's LED blink pattern as well as the MCP2515 driver to the new GPIO API - #20017