-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[TOPIC-GPIO] Convert actinius_icarus and degu_evk boards to new GPIO API #20798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPIC-GPIO] Convert actinius_icarus and degu_evk boards to new GPIO API #20798
Conversation
|
@alextsam Could you verify that the changes for the actinius_icarus board are correct? I don't have such board at hand to check it myself. @takumiando Could you check the changes for the degu_evk board? I don't have this one either. |
|
@anangl Thank you for your fix! I checked and approved your changes. |
|
@anangl the changes are good, thank you! However, should I update also the device tree to use the new defines? eg currently we have |
mnkp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I update also the device tree to use the new defines? eg currently we have
GPIO_INT_ACTIVE_LOWwhich I guess should be replaced withGPIO_ACTIVE_LOWetc
Thanks @alextsam for pointing it out. I overlooked this during the review. It's best if we do it in this PR. I'm marking it as changes requested.
Yes, my bad, I focused only on changes in code and forgot about dts files. Thanks @alextsam! |
In initialization code, pairs of gpio_pin_configure/gpio_pin_write are replaced with calls to gpio_pin_configure that configure a given pin as output with the proper initial state. dts file for the board is also updated with the new GPIO flags. Signed-off-by: Andrzej Głąbek <[email protected]>
dab28f7 to
9804c62
Compare
|
Thank you very much for the changes! One small thing that I just noticed is line 102: the 0 did not matter there before, but now with the logical read this should be fixed to Should I push to anangl:gpio/convert_nrf_boards so then you just squash? |
There is no need to change it. |
In initialization code, pairs of gpio_pin_configure/gpio_pin_write are replaced with calls to gpio_pin_configure that configure a given pin as output with the proper initial state. dts file for the board is also updated with the new GPIO flags. Signed-off-by: Andrzej Głąbek <[email protected]>
9804c62 to
3e273c1
Compare
Pairs of gpio_pin_configure/gpio_pin_write are replaced with calls to
gpio_pin_configure that configure a given pin as output with the proper
initial state.