Test mem alloc fixes #20730
Merged
Test mem alloc fixes #20730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
added
bug
zephyrbot
added
area: Tests
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
ioannisg
force-pushed
the
test_mem_alloc_fixes
branch
from
797417a to
38e286a
Compare
Member
Author
|
@galak I added backport label for LTS - not sure if this is required (i am not sure of the status of newlib libc nano in LTS). you can comment. |
stephanosio
reviewed
Nov 16, 2019
andrewboie
approved these changes
Nov 18, 2019
Some minor typo and style fixes in the README file of tests/lib/mem_alloc test-suite. Signed-off-by: Ioannis Glaropoulos <[email protected]>
libc.newlibcnano test-case shall run with user mode enabled, similarly to the remainder of the test-cases in the tests/lib/mem_alloc test-suite. Signed-off-by: Ioannis Glaropoulos <[email protected]>
When building with NEWLIB_LIBC_NANO we need to copy the globals from libc_nano.a into application memory partition z_libc_partition, exactly as we do for libc.a globals. This is required so that these globals are accessible by nPRIV code, when building with user mode support. Signed-off-by: Ioannis Glaropoulos <[email protected]>
ioannisg
force-pushed
the
test_mem_alloc_fixes
branch
from
38e286a to
b055d8c
Compare
Member
Author
|
Removed the last commit that updated the test-cases .yaml, in the wake of @stephanosio 's feedback. Was tested by @hakehuang , see comment in #20598 |
stephanosio
approved these changes
Nov 18, 2019
MaureenHelm
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20598