[TOPIC-GPIO] samples/subsys/usb/hid-mouse: Convert to use the new GPIO API #20237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the sample to use the new GPIO API and additionally: - add some error messages for unsuccessful GPIO API calls - correct the index of `def_val` element used in the `right_button` callback, to match the one used when the callback is installed - use flags defined in devicetree for the pin that drives the LED (for consistency, as this does not make much difference for a pin that is only toggled) Signed-off-by: Andrzej Głąbek <[email protected]>
anangl
changed the title
masz-nordic
approved these changes
Oct 30, 2019
pabigot
approved these changes
Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the sample to use the new GPIO API and additionally:
def_valelement used in theright_buttoncallback, to match the one used when the callback is installed
(for consistency, as this does not make much difference for a pin
that is only toggled).
Tested on nrf52840_pca10056.