Skip to content

drivers: dma: sam0: fix DMA to peripheral transfer on SAMD5x #20060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2019
Merged

drivers: dma: sam0: fix DMA to peripheral transfer on SAMD5x #20060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions drivers/dma/dma_sam0.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ static int dma_sam0_config(struct device *dev, u32_t channel,
DMAC_CHCTRLA_TRIGSRC(config->dma_slot);
} else {
/* One peripheral trigger per beat */
chcfg->CHCTRLA.reg = DMAC_CHCTRLA_TRIGACT_BURST |
chcfg->CHCTRLA.reg = DMAC_CHCTRLA_TRIGACT_BLOCK |
DMAC_CHCTRLA_TRIGSRC(config->dma_slot);
}

Expand All @@ -161,22 +161,6 @@ static int dma_sam0_config(struct device *dev, u32_t channel,

chcfg->CHPRILVL.bit.PRILVL = config->channel_priority;

/* Set the burst length */
if (config->source_burst_length != config->dest_burst_length) {
LOG_ERR("Source and destination burst lengths must be equal");
goto inval;
}

if (config->source_burst_length > 16U) {
LOG_ERR("Invalid burst length");
goto inval;
}

if (config->source_burst_length > 0U) {
chcfg->CHCTRLA.reg |= DMAC_CHCTRLA_BURSTLEN(
config->source_burst_length - 1U);
}

/* Enable the interrupts */
chcfg->CHINTENSET.reg = DMAC_CHINTENSET_TCMPL;
if (!config->error_callback_en) {
Expand Down