[TOPIC-GPIO] drivers: mmio32: update to use new GPIO API #20028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
changed the title
mnkp
requested changes
Oct 22, 2019
Member
mnkp
left a comment
mnkp
left a comment
There was a problem hiding this comment.
LGTM, however there is still some old code in gpio_mmio32_config function using GPIO_DIR_*, GPIO_POL_* flags. We could also remove invert field from struct gpio_mmio32_context in include/drivers/gpio/gpio_mmio32.h. The gpio_mmio32_write, gpio_mmio32_read functions should use invert field from struct gpio_driver_data.
galak
requested review from
MaureenHelm,
carlescufi and
nashif
as code owners
Contributor
Author
made some changes, so hopefully all this is clean up. |
mnkp
reviewed
Oct 24, 2019
As the mmio32 is more of a library than a proper driver, just implement the new port functions and have pin_interrupt_configure marked pretty much as not supported. Signed-off-by: Kumar Gala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the mmio32 is more of a library than a proper driver, just implement
the new port functions and have pin_interrupt_configure marked pretty
much as not supported.
Signed-off-by: Kumar Gala [email protected]