[TOPIC-GPIO] drivers: sensor: hts221: update to new GPIO API #19834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
requested review from
avisconti,
carlescufi,
ioannisg and
lemrey
as code owners
|
All checks passed. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
pabigot
force-pushed
the
gpio/hts221
branch
3 times, most recently
from
40747f1 to
f2c572a
Compare
mnkp
reviewed
Oct 16, 2019
pabigot
requested review from
MaureenHelm,
erwango,
galak and
rsalveti
as code owners
Contributor
Author
|
@mnkp Updated to use the device-tree specified active level. As a best practice I'm also documenting in the device yaml file what the sensor-provided active level is, as deviations from that must be handled properly. Note that two existing boards specified the wrong active level in their devicetree nodes. |
zephyrbot
added
the
area: Tests
mnkp
reviewed
Oct 17, 2019
mnkp
reviewed
Oct 17, 2019
mnkp
approved these changes
Oct 17, 2019
Member
erwango
approved these changes
Oct 24, 2019
Correct DRDY active level to default active-high, switch to new interrupt configuration. Also fix a common bug where an already-active DRDY signal is not properly handled. Signed-off-by: Peter Bigot <[email protected]>
galak
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct DRDY active level to default active-high, switch to new interrupt configuration.
Tested on nrf52_pca20020 (Thingy:52) and (after much pain unrelated to this change) frdm_k64f with the x_nucleo_iks01a2 shield.
NOTE: This PR also contains #19862 and #19870 on which it depends.