drivers: clock_control: nrf_power_clock: Make isr function global #19673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-krch
added
area: Clock Control
Trivial
ioannisg
approved these changes
Oct 8, 2019
Member
ioannisg
left a comment
ioannisg
left a comment
There was a problem hiding this comment.
OK, but add an inline comment. I think the nrf_rtc_timer has a similar comment there.
carlescufi
approved these changes
Oct 8, 2019
Some tests are failing because nrf_power_clock_isr was static. Signed-off-by: Krzysztof Chruscinski <[email protected]>
nordic-krch
force-pushed
the
fix_nrf_power_clock_isr_linking
branch
from
00ab260 to
053a1e3
Compare
Contributor
Author
|
@ioannisg comment was present but at isr implementation. It was earlier declared to be used earlier and declaration was static. I moved the comment there. |
pabigot
approved these changes
Oct 8, 2019
Member
Right, that's exactly what I wanted |
ioannisg
added
the
Hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing because nrf_power_clock_isr was static.
Apparently, some tests are using irq function (
zephyr/tests/arch/arm/arm_irq_vector_table/src/arm_irq_vector_table.c
Line 165 in 288940d
Fixes #19683.
Signed-off-by: Krzysztof Chruscinski [email protected]