[TOPIC-GPIO] gpio: Update rv32m1 gpio driver to use new gpio api #19664
Conversation
zephyrbot
added
area: Boards
area: Tests
drivers/gpio/gpio_rv32m1.c
Outdated
There was a problem hiding this comment.
This check is already implemented in gpio_rv32m1_pin_interrupt_configure. We could skip it here.
There was a problem hiding this comment.
This is the same as the mcux driver. Can we postpone these changes to a future PR to keep mcux and rv32m1 in sync?
drivers/gpio/gpio_rv32m1.c
Outdated
There was a problem hiding this comment.
This is handled by gpio_rv32m1_pin_interrupt_configure function.
drivers/gpio/gpio_rv32m1.c
Outdated
There was a problem hiding this comment.
We're mixing styles. To be consistent / Misra-C compliant we would need to write it as
if (((flags & GPIO_INT_ENABLE) != 0) && ((flags & GPIO_INPUT) == 0)) {
There was a problem hiding this comment.
Actually, I believe we should move this check to gpio_rv32m1_pin_interrupt_configure function (and read input/output configuration from the register).
drivers/gpio/gpio_rv32m1.c
Outdated
There was a problem hiding this comment.
No, it is still needed
There was a problem hiding this comment.
The code on line 162 will clear IRQ configuration from PCR register but we don't configure interrupts here. If we merge #19553 the gpio_rv32m1_configure would still modify interrupt configuration.
drivers/gpio/gpio_rv32m1.c
Outdated
There was a problem hiding this comment.
This function is not used anymore by gpio_rv32m1_configure. We could move it directly above gpio_rv32m1_pin_interrupt_configure. It would make the code easier to read.
|
@MaureenHelm |
Done |
|
@pabigot and @mnkp from the API meeting: @MaureenHelm would like to merge this as-is and follow-up as described here. Could you approve? |
Explicitly configures the rgb led pinmuxes as gpios. Currently the gpio driver quietly changes the pinmux to gpio mode when configuring a gpio pin, but this behavior is about to change. Signed-off-by: Maureen Helm <[email protected]>
Updates the rv32m1 gpio driver and all associated boards to use new device tree compatible gpio configuration flags. Implements new port get/set/clear/toggle and pin_interrupt_configure functions recently added to the gpio api. Assumes the gpio api layer handles translating logical flags to physical flags. Stops quietly reconfiguring pinmuxes to gpio mode. The pinmux must now be configured explicitly in the board's pinmux.c or in the application. Tested with: - samples/basic/blinky - samples/basic/button - tests/drivers/gpio/gpio_api_1pin On boards: - rv32m1_vega_ri5cy Signed-off-by: Maureen Helm <[email protected]>
Enables the 2-pin gpio test on the rv32m1_vega_ri5cy board by adding a dts overlay and configuring pinmuxes on the arduino header. Signed-off-by: Maureen Helm <[email protected]>
5 participants
Updates the rv32m1 gpio driver and all associated boards to use new
device tree compatible gpio configuration flags. Implements new port
get/set/clear/toggle and pin_interrupt_configure functions recently
added to the gpio api.
Assumes the gpio api layer handles translating logical flags to physical
flags.
Stops quietly reconfiguring pinmuxes to gpio mode. The pinmux must now
be configured explicitly in the board's pinmux.c or in the application.
Tested with:
On boards:
Passes most, but not all of the 2-pin test.