[TOPIC-GPIO] drivers: gpio_dw: update to use new GPIO API #19631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
requested review from
mnkp,
pabigot,
ruuddw and
vonhust
as code owners
zephyrbot
added
area: Boards
area: Tests
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
pabigot
suggested changes
Oct 7, 2019
dcpleung
force-pushed
the
dw_gpio_api
branch
2 times, most recently
from
654b130 to
0029fc2
Compare
pabigot
reviewed
Oct 7, 2019
mnkp
requested changes
Oct 8, 2019
mnkp
approved these changes
Oct 8, 2019
Member
|
@dcpleung |
This adds a board overlay for em_starterkit in the gpio_basic_api test. Signed-off-by: Daniel Leung <[email protected]>
Changes GPIO_INT_ACTIVE_LOW to GPIO_ACTIVE_LOW. Signed-off-by: Daniel Leung <[email protected]>
Changes GPIO_INT_ACTIVE_LOW to GPIO_ACTIVE_LOW. Signed-off-by: Daniel Leung <[email protected]>
Update driver code and board files to use new GPIO configuration flags such as GPIO_ACTIVE_LOW. Also add implementation of new port_* driver API as well as gpio_pin_interrupt_configure function. The interrupt triggering on both edges is a remnant from the old Quark SE which has a customized DesignWare GPIO block. So remove the support for both edges as the board is no longer supported. Signed-off-by: Daniel Leung <[email protected]>
Member
Author
Done. |
pabigot
approved these changes
Oct 11, 2019
MaureenHelm
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the gpio_dw driver to the new GPIO API. It also adds an overlay to the gpio_basic_api test, and updates the DTS files for board emsdp/em_starterkit.
This has been tested with gpio_basic_api.