[TOPIC-GPIO] drivers: stellaris: update to use new GPIO API

[galak]

Update driver code and board files to use new GPIO configuration flags
such as GPIO_ACTIVE_LOW. Also add implementation of new port_* driver
API as well as gpio_pin_interrupt_configure function.

Signed-off-by: Kumar Gala [email protected]

[pabigot]

AFAICT this platform exists only as a basis for qemu_cortex_m3, which says:

.. note::
   This board configuration makes no claims about its suitability for use
   with an actual ti_lm3s6965 hardware system, or any other hardware system.

Why are we keeping this?

[mnkp]

The gpio_stellaris_configure function should also be updated.

[mnkp]

Seems like this PR was rebased but no changes to the driver code were applied.

[galak]

Seems like this PR was rebased but no changes to the driver code were applied.

should be fixed now.

[mnkp]

It seems like it's again the same version, no changes.

[galak]

Line 194 should be changed. That was the only review comment that was made.

[mnkp]

I've opened the PR in another browser, just in case, still the line 194 is written as

	sys_write32(GPIO_RW_MASK_ADDR(base, GPIO_DATA_OFFSET, value), mask);

which is the original. I believe it should be written as

	sys_write32(value, GPIO_RW_MASK_ADDR(base, GPIO_DATA_OFFSET, mask));

since

void sys_write32(u32_t data, mem_addr_t addr);

Apart from line 194 also gpio_stellaris_configure function should be updated.

[galak]

I've opened the PR in another browser, just in case, still the line 194 is written as

	sys_write32(GPIO_RW_MASK_ADDR(base, GPIO_DATA_OFFSET, value), mask);

which is the original. I believe it should be written as

	sys_write32(value, GPIO_RW_MASK_ADDR(base, GPIO_DATA_OFFSET, mask));

since

void sys_write32(u32_t data, mem_addr_t addr);

Apart from line 194 also gpio_stellaris_configure function should be updated.

Gotcha, sorry bit a little while since I worked on the driver. Should now hopefully be fixed correctly.

[mnkp]

It worked. However, we also need to update gpio_stellaris_configure function. It contains old interrupt configuration code and is using deprecated masks, like GPIO_DIR_IN.

[galak]

It worked. However, we also need to update gpio_stellaris_configure function. It contains old interrupt configuration code and is using deprecated masks, like GPIO_DIR_IN.

Should now be updated.

[zephyrbot]

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

[galak]

Not sure I follow where in the code we should handle 'disconnected' mode.

Was thinking we'd have:

if (flags & INPUT)
...
else if (flags & OUTPUT)
...
else
/* disconnect */

[mnkp]

Was thinking we'd have:

if (flags & INPUT)
...
else if (flags & OUTPUT)
...
else
/* disconnect */

This version of the code looks good with the only remark that we should test first for GPIO_OUTPUT flag and then have } else if (flags & INPUT) {. If we swap the branches the code should also work if user passes both flags simultaneously (GPIO_OUTPUT | GPIO_INPUT). The pin will be configured as an output, but the input direction should also work as long as the pin is in push-pull mode.