Skip to content

modules: hal: nordic: Remove dependency on DT from NRF_* mappings #19269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2019
Merged

modules: hal: nordic: Remove dependency on DT from NRF_* mappings #19269

merged 1 commit into from
Sep 20, 2019

Conversation

@anangl
Copy link
Member

@anangl anangl commented Sep 19, 2019

Update the module revision so that the following commit becomes
effective:

  • nrfx_config_nrf9160: Remove dependency on DT from NRF_* mappings

Requires zephyrproject-rtos/hal_nordic#4 to go in first.

@anangl anangl added area: Drivers platform: nRF Nordic nRFx Blocked Blocked by another PR or issue DNM This PR should not be merged (Do Not Merge) labels Sep 19, 2019
@pabigot pabigot self-requested a review September 19, 2019 11:37
pabigot
pabigot approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@pabigot pabigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to decouple that module from devicetree churn.

@anangl anangl mentioned this pull request Sep 20, 2019
Merged
@anangl anangl force-pushed the simplify_nrfx_config_nrf9160 branch from 44dca46 to aa46694 Compare September 20, 2019 11:10
@anangl
Copy link
Member Author

anangl commented Sep 20, 2019

Pushed amended commit with no changes, to re-trigger CI and check the recent changes made in zephyrproject-rtos/hal_nordic#4.

@ioannisg
Copy link
Member

Pushed amended commit with no changes, to re-trigger CI and check the recent changes made in zephyrproject-rtos/hal_nordic#4.

Could re-trigger by close/re-open, too.

@anangl
Copy link
Member Author

anangl commented Sep 20, 2019

Pushed amended commit with no changes, to re-trigger CI and check the recent changes made in zephyrproject-rtos/hal_nordic#4.

Could re-trigger by close/re-open, too.

I know, just thought this way it would be looking a bit nicer.

@anangl anangl force-pushed the simplify_nrfx_config_nrf9160 branch from aa46694 to 10e92f6 Compare September 20, 2019 14:03
@anangl
Copy link
Member Author

anangl commented Sep 20, 2019

Updated west.yml with the proper revision of the hal_nordic module as zephyrproject-rtos/hal_nordic#4 has been merged.

@anangl
modules: hal: nordic: Remove dependency on DT from NRF_* mappings
60bbba6 
Update the module revision so that the following commit becomes
effective:

* nrfx_config_nrf9160: Remove dependency on DT from NRF_* mappings

Signed-off-by: Andrzej Głąbek <[email protected]>
@anangl anangl force-pushed the simplify_nrfx_config_nrf9160 branch from 10e92f6 to 60bbba6 Compare September 20, 2019 14:04
@anangl
Copy link
Member Author

anangl commented Sep 20, 2019

Sorry, I haven't included the change done to west.yml in the previous push.

@anangl anangl removed Blocked Blocked by another PR or issue DNM This PR should not be merged (Do Not Merge) labels Sep 20, 2019
@ioannisg
Copy link
Member

Don't you want to include also #5 from the hal-nordic repo?

@ioannisg
Copy link
Member

ioannisg commented Sep 20, 2019 •
edited
Loading

This one
zephyrproject-rtos/hal_nordic#5
could be merged, if you run CI here, that includes that commit

@ioannisg
Copy link
Member

...or you can do that in a separate PR.

@ioannisg ioannisg merged commit 97e38c2 into zephyrproject-rtos:master Sep 20, 2019
@anangl anangl deleted the simplify_nrfx_config_nrf9160 branch September 20, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galak galak galak approved these changes

@kl-cruz kl-cruz Awaiting requested review from kl-cruz

@carlescufi carlescufi Awaiting requested review from carlescufi

+2 more reviewers

@pabigot pabigot pabigot approved these changes

@ioannisg ioannisg ioannisg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: Drivers area: Modules platform: nRF Nordic nRFx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anangl @ioannisg @pabigot @galak @zephyrbot