POSIX: pthread_cond_timedwait, pthread_mutex_timedlock should use absolute deadline param #18708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, it was coded as if it accepted a relative timeout. Normative reference: http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_cond_timedwait.html Fixes: zephyrproject-rtos#17812 Signed-off-by: Paul Sokolovsky <[email protected]>
It was coded as if it accepts relative timeout. Normative reference: http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_timedlock.html Signed-off-by: Paul Sokolovsky <[email protected]>
pfalcon
added
priority: medium
Contributor
Author
|
This is from-scratch alternative to #17813, containing absolutely minimal set of changes to fix reported issues, to not introduce further issues, like leaking of private functions into public headers, renaming unrelated functions in a way which may conflict with ANSI C/MISRA C (using leading underscore), etc. |
nashif
approved these changes
Aug 27, 2019
ioannisg
approved these changes
Aug 27, 2019
jimparis
approved these changes
Aug 27, 2019
Contributor
jimparis
left a comment
jimparis
left a comment
There was a problem hiding this comment.
Tested & working. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 POSIX Pthreads functions incorrectly treating their param as a relative timeout, instead of absolute deadline, as spotted by @jimparis in #17812, #17813.
Fixes: #17812