lib: posix: Use "posix_subsys" as the CMake lib for the subsystem. #18087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aescolar
reviewed
Aug 7, 2019
Member
aescolar
left a comment
aescolar
left a comment
There was a problem hiding this comment.
What would you think about calling it POSIX_API instead?
(to be a bit clearer about what it is, and avoid confusion with the posix arch and native_posix)
Contributor
Author
Well, just implementing suggestion from @nashif: https://github.com/zephyrproject-rtos/zephyr/pull/15937/files#r294496946
I'm not sure that POSIX_API is the best choice then, something like "POSIX_SUBSYS" would be even clearer (and yeah, I'm not sure about that upper case). Will look into it. |
Historically, it used to be "PTHREAD", which is no longer true, as POSIX subsys offers much more functionality than just Pthreads. Use detailed name, like "posix_subsys", to avoid possible confusion with ARCH_POSIX-related matters. Signed-off-by: Paul Sokolovsky <[email protected]>
pfalcon
force-pushed
the
posix-posix-lib
branch
from
6faf4e6 to
688750c
Compare
pfalcon
changed the title
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, it used to be "PTHREAD", which is no longer true, as
POSIX subsys offers much more functionality than just Pthreads.
Signed-off-by: Paul Sokolovsky [email protected]