[TOPIC-GPIO] Add LiteX GPIO driver #18038

mateusz-holenko · 2019-08-06T11:27:42Z

This adds LiteX GPIO driver and enables it in litex_vexriscv board.

zephyrbot · 2019-08-06T11:41:57Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

CODEOWNERS

dts/bindings/gpio/litex,gpio.yaml

galak

Minor change to DTS binding.

dts/bindings/gpio/litex,gpio.yaml

galak · 2019-08-07T14:02:56Z

You'll need the fix in:

#18089

Also, instead of nrgpios we need to make ngpios (sorry for the churn on that).

galak · 2019-08-07T17:22:03Z

You'll need the fix in:

#18089

Also, instead of nrgpios we need to make ngpios (sorry for the churn on that).

Re-based and fixed up the yaml to be ngpios

mateusz-holenko · 2019-08-08T05:46:32Z

You'll need the fix in:
#18089
Also, instead of nrgpios we need to make ngpios (sorry for the churn on that).

Re-based and fixed up the yaml to be ngpios

Thanks.

mateusz-holenko · 2019-08-08T13:35:18Z

I fixed the base addresses of gpio ports in the DTS.

mateusz-holenko · 2019-08-19T09:46:07Z

@galak Is there anything else I should do to have this PR merged?

mateusz-holenko · 2019-09-19T07:46:07Z

@galak The code is rebased on top of the 2.0.0 release and all requested changes are applied. Can we merge it?

mateusz-holenko · 2019-09-23T06:58:33Z

Rebased to resolve conflicts after merging #18649.

zephyrbot · 2019-09-23T07:25:07Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

mateusz-holenko · 2019-10-01T14:55:09Z

@galak Is there something blocking this PR from being merged?

galak · 2019-10-01T16:20:00Z

@galak Is there something blocking this PR from being merged?

We should migrate it to the new GPIO apis in the 'topic-gpio' branch. See issue #18530

mateusz-holenko · 2019-10-28T09:45:23Z

@mnkp You are right - I had pushed a wrong branch. Sorry for the confussion.

It's fixed now - the current version is using the new GPIO API and the PR is now targetting topic-gpio branch.

mnkp

It seems like this PR is missing updates of the soc .dts file.

drivers/gpio/gpio_litex.c

dts/bindings/gpio/litex,gpio.yaml

drivers/gpio/gpio_litex.c

PiotrZierhoffer · 2019-11-05T15:23:58Z

@mnkp you mention lack of changes to the soc dts. I believe the relevant changes are in riscv32-litex-vexriscv.dtsi. Am I missing something?

mnkp · 2019-11-05T15:42:39Z

@mnkp you mention lack of changes to the soc dts. I believe the relevant changes are in riscv32-litex-vexriscv.dtsi. Am I missing something?

Yes, they are. Sorry, I somehow overlooked the file.

PiotrZierhoffer · 2019-11-06T11:39:31Z

@mnkp the requested changes are implemented, tested and pushed.

galak · 2019-11-13T18:14:46Z

Can you rebase this on topic-gpio thanks.

mateusz-holenko · 2019-11-15T11:45:07Z

@galak It's rebased

carlescufi · 2019-11-19T17:45:39Z

@galak can you take another look?

Stale

carlescufi · 2019-11-25T16:36:22Z

@galak @pabigot can we merge this?

pabigot

I don't have this board and haven't inspected this closely, and a quick search didn't locate any documentation (was curious about only having 4 GPIO signals supported).

Assuming it passes both tests the only thing that I'd recommend doing is below. I won't insist on it since the issue's likely to be fixed before the topic branch merges.

drivers/gpio/gpio_litex.c

dts/bindings/gpio/litex,gpio.yaml

galak

minor dts binding update needed.

This commits adds GPIO driver for LiteX SoC builder. Due to the fact that GPIO in LiteX is unidirectional and can be configured with different pins amount per port, additional entries were added to the dts file. Signed-off-by: Robert Winkler <[email protected]> Signed-off-by: Mateusz Holenko <[email protected]> Signed-off-by: Piotr Zierhoffer <[email protected]>

Enable LiteX GPIO driver in litex_vexriscv board. Signed-off-by: Robert Winkler <[email protected]> Signed-off-by: Mateusz Holenko <[email protected]> Signed-off-by: Piotr Zierhoffer <[email protected]>

mateusz-holenko requested review from kgugala, nategraff-sifive and pgielda as code owners August 6, 2019 11:27

zephyrbot added area: Devicetree area: Boards labels Aug 6, 2019

mateusz-holenko force-pushed the litex_gpio branch from 6339ac0 to a4fa26d Compare August 6, 2019 13:58

galak reviewed Aug 6, 2019

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

galak reviewed Aug 6, 2019

View reviewed changes

dts/bindings/gpio/litex,gpio.yaml Outdated Show resolved Hide resolved

galak previously requested changes Aug 6, 2019

View reviewed changes

galak reviewed Aug 7, 2019

View reviewed changes

dts/bindings/gpio/litex,gpio.yaml Outdated Show resolved Hide resolved

mateusz-holenko force-pushed the litex_gpio branch from a4fa26d to 0dee24a Compare August 7, 2019 12:52

galak force-pushed the litex_gpio branch from 0dee24a to 32b2b1c Compare August 7, 2019 17:20

mateusz-holenko force-pushed the litex_gpio branch from 32b2b1c to 421abbf Compare August 8, 2019 13:33

mateusz-holenko force-pushed the litex_gpio branch from 421abbf to 36d411c Compare August 12, 2019 08:54

kgugala force-pushed the litex_gpio branch 2 times, most recently from 05e2fce to 758db80 Compare September 11, 2019 16:32

mateusz-holenko force-pushed the litex_gpio branch from 758db80 to 48e14d8 Compare September 23, 2019 06:57

mateusz-holenko force-pushed the litex_gpio branch from 48e14d8 to d26ff17 Compare September 23, 2019 08:07

mnkp added the area: GPIO label Oct 13, 2019

mnkp requested changes Oct 30, 2019

View reviewed changes

PiotrZierhoffer force-pushed the litex_gpio branch from 0a0a998 to fccde29 Compare November 6, 2019 10:17

henrikbrixandersen removed request for henrikbrixandersen and scottwcpg November 6, 2019 19:25

mnkp approved these changes Nov 10, 2019

View reviewed changes

galak force-pushed the topic-gpio branch from 1097995 to a205c54 Compare November 13, 2019 18:09

mateusz-holenko force-pushed the litex_gpio branch 2 times, most recently from ea64d74 to c0350aa Compare November 14, 2019 08:00

pabigot changed the title ~~Add LiteX GPIO driver~~ [TOPIC-GPIO] Add LiteX GPIO driver Nov 25, 2019

pabigot reviewed Nov 25, 2019

View reviewed changes

drivers/gpio/gpio_litex.c Outdated Show resolved Hide resolved

mateusz-holenko force-pushed the litex_gpio branch from c0350aa to a58f4ba Compare November 27, 2019 15:18

mateusz-holenko requested a review from pabigot December 3, 2019 13:21

galak reviewed Dec 3, 2019

View reviewed changes

dts/bindings/gpio/litex,gpio.yaml Outdated Show resolved Hide resolved

galak requested changes Dec 3, 2019

View reviewed changes

mateusz-holenko force-pushed the litex_gpio branch from a58f4ba to e9d1cce Compare December 4, 2019 08:17

rw1nkler added 2 commits December 4, 2019 09:28

boards: litex_vexriscv: Enable LiteX GPIO driver

da934e3

Enable LiteX GPIO driver in litex_vexriscv board. Signed-off-by: Robert Winkler <[email protected]> Signed-off-by: Mateusz Holenko <[email protected]> Signed-off-by: Piotr Zierhoffer <[email protected]>

mateusz-holenko force-pushed the litex_gpio branch from e9d1cce to da934e3 Compare December 4, 2019 08:32

galak approved these changes Dec 4, 2019

View reviewed changes

galak merged commit 8f41c2f into zephyrproject-rtos:topic-gpio Dec 11, 2019

galak mentioned this pull request Jan 26, 2020

Convert GPIO drivers to new GPIO API #18530

Closed

[TOPIC-GPIO] Add LiteX GPIO driver #18038

[TOPIC-GPIO] Add LiteX GPIO driver #18038

Uh oh!

Conversation

mateusz-holenko commented Aug 6, 2019

Uh oh!

zephyrbot commented Aug 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

galak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

galak commented Aug 7, 2019

Uh oh!

galak commented Aug 7, 2019

Uh oh!

mateusz-holenko commented Aug 8, 2019

Uh oh!

mateusz-holenko commented Aug 8, 2019

Uh oh!

mateusz-holenko commented Aug 19, 2019

Uh oh!

mateusz-holenko commented Sep 19, 2019

Uh oh!

mateusz-holenko commented Sep 23, 2019

Uh oh!

zephyrbot commented Sep 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateusz-holenko commented Oct 1, 2019

Uh oh!

galak commented Oct 1, 2019

Uh oh!

mateusz-holenko commented Oct 28, 2019

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrZierhoffer commented Nov 5, 2019

Uh oh!

mnkp commented Nov 5, 2019

Uh oh!

PiotrZierhoffer commented Nov 6, 2019

Uh oh!

galak commented Nov 13, 2019

Uh oh!

mateusz-holenko commented Nov 15, 2019

Uh oh!

carlescufi commented Nov 19, 2019

Uh oh!

carlescufi commented Nov 25, 2019

Uh oh!

pabigot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

galak left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zephyrbot commented Aug 6, 2019 •

edited

Loading

zephyrbot commented Sep 23, 2019 •

edited

Loading