zio: Introduce hts221 humidity sensor #17921

avisconti · 2019-07-31T14:31:41Z

depends on #16119
Prepare HTS221 driver based on zio interface.
This sensor component does not have an internal hardware FIFO. Nevertheless
I defined a s/w fifo of length==1. I will try later on with other sensors with h/w fifo.

In order to test it on the x_nucleo_shield3 is rebased on master and not topic-sensors.
I can later switch it if needed

Add a new sensor device API called zio_dev along with supporting interface and implmentations needed to better encapsulate a large range of functionality typical sampled input/output (sensor and signal generator) type devices commonly provide. Every device has a set of channels and attributes associated with it. Channels may be attached to a fifo like interface (zio_buf) which provides a pollable mechanism for obtaining the raw channel data at a designated watermark level. Signed-off-by: Tom Burdick <[email protected]>

Provide a software only example driver and sample application which generates a left and right sine wave at CD quality bit width and rate. Signed-off-by: Tom Burdick <[email protected]>

Rather than providing the attribute values directly in get_attrs for zio devices and channels, provide descriptions of each attribute. This should allow a driver to map many attributes directly to registers or internalized struct members and avoid storing these values in a zio_variant which is confusing. Signed-off-by: Tom Burdick <[email protected]>

Update synth driver and sample to use attribute descriptions Signed-off-by: Tom Burdick <[email protected]>

Add placeholder and fix duplicated label to in docs to make ci happy Signed-off-by: Tom Burdick <[email protected]>

Adds device tree bindings and nodes for the ft5336 capacitive touch sensor to the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <[email protected]>

Introduces a new zio driver for the ft5336 capacitive touch sensor. Signed-off-by: Maureen Helm <[email protected]>

Adds support for LittlevGL input devices using the new zio interface. This should ultimately be independent of the specific touch controller, however it is currently tied to the ft5336 due to the lack of an abstracted touch sensor data type. We also have not implemented gpio interrupts in the ft5336 driver and therefore rely on manual triggering, making the touch input appear a bit laggy in the gui. Signed-off-by: Maureen Helm <[email protected]>

Configures LittlevGL to use the ft5336 capacitive touch sensor input by default on the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <[email protected]>

Enables the touch sensor input and adds a keyboard object to the LittlevGL sample application. This is a hack, do not merge! Signed-off-by: Maureen Helm <[email protected]>

Prior to this patch, zio only supported u32_t variants. Add support for wrapping and unwrapping u8_t variants so the ft5336 driver can implement a new u8_t attribute. Signed-off-by: Maureen Helm <[email protected]>

Adds a read/write device attribute to the ft5336 zio driver to runtime configure the number of touches to push to the fifo. The ft5336 hardware can support up to five simultaneous touches, but some applications like LittlevGL only use a single touch. Signed-off-by: Maureen Helm <[email protected]>

LittlevGL doesn't suport multitouch inputs, so use the zio attribute setter interface to configure the ft5336 driver to only push single touches to the zio fifo. Signed-off-by: Maureen Helm <[email protected]>

ulfalizer · 2019-08-06T23:27:50Z

drivers/Kconfig


+source "drivers/zio/Kconfig"
+
+


Accidental extra blank line.

ulfalizer · 2019-08-06T23:28:16Z

drivers/sensor/CMakeLists.txt

 add_subdirectory_ifdef(CONFIG_HP206C		hp206c)
-add_subdirectory_ifdef(CONFIG_HTS221		hts221)
+# test hts221 from zio
+#add_subdirectory_ifdef(CONFIG_HTS221		hts221)


Leftover debugging?

ulfalizer · 2019-08-06T23:28:30Z

drivers/sensor/Kconfig


-source "drivers/sensor/hts221/Kconfig"
+# test hts221 from zio
+#source "drivers/sensor/hts221/Kconfig"


Leftover debugging?

ulfalizer · 2019-08-06T23:31:22Z

dts/bindings/sensor/focaltech,ft5336.yaml

+#
+# SPDX-License-Identifier: Apache-2.0
+#
+---


Redundant document separator (see #16913).

ulfalizer · 2019-08-06T23:31:31Z

dts/bindings/sensor/focaltech,ft5336.yaml

+      type: compound
+      category: optional
+      generation: define, use-prop-name
+...


Redundant document separator (see #16913).

teburd · 2019-08-13T15:09:51Z

@avisconti Glad to see another driver being written against this API, the current API I believe needs more refinement and I began working on that in another PR.

I would love feedback on the API as it stands here from you as you've now written a driver for it.

I'd also love to get feedback on what I think is a simpler version of this idea in this pull request
#17434

I think topic sensors needs to be rebased anyways, I'll see if I can do it or if I can find someone to do it for me. Then I can take a closer look at this

carlescufi · 2019-08-27T16:35:32Z

@avisconti zio has been replaced with rtio. #16119 will be rewritten to target rtio, and once that is done we need to do the same with this PR.

avisconti · 2019-09-02T12:28:30Z

@avisconti zio has been replaced with rtio. #16119 will be rewritten to target rtio, and once that is done we need to do the same with this PR.

Yes, sure. Thanks!
I'll constantly catch up with latest news.

teburd and others added 23 commits July 23, 2019 11:27

zio: Example synth driver

76833b5

Provide a software only example driver and sample application which generates a left and right sine wave at CD quality bit width and rate. Signed-off-by: Tom Burdick <[email protected]>

zio: synth: use attribute descriptions

eb19e2b

Update synth driver and sample to use attribute descriptions Signed-off-by: Tom Burdick <[email protected]>

zio: documentation

197bc58

Add placeholder and fix duplicated label to in docs to make ci happy Signed-off-by: Tom Burdick <[email protected]>

dts: boards: Add ft5336 touch sensor dts bindings and nodes

2858105

Adds device tree bindings and nodes for the ft5336 capacitive touch sensor to the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <[email protected]>

drivers: zio: Introduce ft5336 touch sensor driver

ba53046

Introduces a new zio driver for the ft5336 capacitive touch sensor. Signed-off-by: Maureen Helm <[email protected]>

boards: Configure LittlevGL input defaults on mimxrt10{50,60,64}_evk

817b9d3

Configures LittlevGL to use the ft5336 capacitive touch sensor input by default on the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <[email protected]>

samples: gui: Hack the LittlevGL sample to use touch input

4ebb548

Enables the touch sensor input and adds a keyboard object to the LittlevGL sample application. This is a hack, do not merge! Signed-off-by: Maureen Helm <[email protected]>

zio: Add support for wrapping/unwrapping u8_t variants

6cc0d3b

Prior to this patch, zio only supported u32_t variants. Add support for wrapping and unwrapping u8_t variants so the ft5336 driver can implement a new u8_t attribute. Signed-off-by: Maureen Helm <[email protected]>

lib: gui: Configure LittlevGL touch input driver to single touch

854aea4

LittlevGL doesn't suport multitouch inputs, so use the zio attribute setter interface to configure the ft5336 driver to only push single touches to the zio fifo. Signed-off-by: Maureen Helm <[email protected]>

driver/sensors: remove hts221 because we need to test the zio driver

0e2e062

drivers/zio: Add support for hts221

15efbab

board/shield/iks01a3: configure drdy in overlay (standard mode)

18c13d4

sample/shield/iks01a3/standard: test hts221 zio driver

414cbbd

driver/hts221: add channels

384b2db

drivers/hts221: fix warning (deprecated)

b1224f5

drivers/hts221: Add spi

d4b8158

dts/ginding: Add spi to hts221

65b8928

boards/shield/x_nucleo_iks01a3: add spi

254d9f3

samples/x_nucleo_iks01a3: add spi

9bb9988

avisconti added area: Sensors Sensors area: API Changes to public APIs labels Jul 31, 2019

avisconti requested review from MaureenHelm, microbuilder, teburd, ulfalizer and vanwinkeljan July 31, 2019 14:31

ulfalizer reviewed Aug 6, 2019

View reviewed changes

drivers/Kconfig

source "drivers/zio/Kconfig"

Copy link

Contributor

ulfalizer Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidental extra blank line.

ulfalizer reviewed Aug 6, 2019

View reviewed changes

vanwinkeljan removed their request for review November 21, 2019 16:37

github-actions bot added area: Boards area: Devicetree area: Documentation has-conflicts Issue/PR has conflicts with another issue/PR area: Device Tree area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jun 29, 2020

galak removed the area: Device Tree label Jul 1, 2020

github-actions bot added has-conflicts Issue/PR has conflicts with another issue/PR area: Shields Shields (add-on boards) platform: NXP NXP and removed has-conflicts Issue/PR has conflicts with another issue/PR labels Jul 1, 2020

nashif added the Stale label Sep 7, 2020

github-actions bot closed this Sep 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

zio: Introduce hts221 humidity sensor #17921

zio: Introduce hts221 humidity sensor #17921

Uh oh!

avisconti commented Jul 31, 2019 •

edited

Loading

Uh oh!

ulfalizer Aug 6, 2019

Uh oh!

ulfalizer Aug 6, 2019

Uh oh!

ulfalizer Aug 6, 2019

Uh oh!

ulfalizer Aug 6, 2019

Uh oh!

ulfalizer Aug 6, 2019

Uh oh!

teburd commented Aug 13, 2019 •

edited

Loading

Uh oh!

carlescufi commented Aug 27, 2019

Uh oh!

avisconti commented Sep 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zio: Introduce hts221 humidity sensor #17921

zio: Introduce hts221 humidity sensor #17921

Uh oh!

Conversation

avisconti commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ulfalizer Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

ulfalizer Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

ulfalizer Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

ulfalizer Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

ulfalizer Aug 6, 2019

Choose a reason for hiding this comment

Uh oh!

teburd commented Aug 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlescufi commented Aug 27, 2019

Uh oh!

avisconti commented Sep 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

avisconti commented Jul 31, 2019 •

edited

Loading

teburd commented Aug 13, 2019 •

edited

Loading