Skip to content

Conversation

@Blackladder
Copy link
Contributor

@Blackladder Blackladder commented Jul 2, 2019

Add read remote version on startup and added to bt_conn_get_info.

Added remote features to bt_get_conn_info (and to the bt_conn_le_info struct)
Added remote version struct to bt_conn_info union.

If CONFIG_BT_TESTING is enabled:
-read_remote_version is called on connection
-bt_conn has an extra remote_version struct in the union
-bt_conn_get_info also gives remote version information

note: read_remote_features is already called on connection

Signed-off-by: Sverre Storvold [email protected]

@zephyrbot
Copy link

zephyrbot commented Jul 2, 2019

Found the following issues, please fix and resubmit:

Gitlint issues

Commit eff10f7257:
1: UC2 Signed-off-by: must have a full name
1: UC3 Title does not follow [subsystem]: [subject] (and should not start with literal subsys:): "Fixed spacing"
1: UC6 Body has no content, should at least have 1 line.

Commit 7248356509:
1: UC2 Body does not contain a 'Signed-off-by:' line
1: UC6 Body has no content, should at least have 1 line.
3: B6 Body message is missing

Identity/Emails issues

eff10f7257916a7cbfa0eba2d654807f08b29ec2: author email (Storvold, Sverre [email protected]) does not follow the syntax: First Last .

72483565097904c69c7a4282a7183fde175f2437: author email (Storvold, Sverre [email protected]) needs to match one of the signed-off-by entries.
72483565097904c69c7a4282a7183fde175f2437: author email (Storvold, Sverre [email protected]) does not follow the syntax: First Last .

@Blackladder Blackladder closed this Jul 2, 2019
@Blackladder Blackladder reopened this Jul 2, 2019
@Blackladder Blackladder closed this Jul 2, 2019
@Blackladder
Copy link
Contributor Author

Added signed off line to original comment.

@Blackladder Blackladder reopened this Jul 2, 2019
@Blackladder Blackladder closed this Jul 2, 2019
@Blackladder Blackladder reopened this Jul 2, 2019
Signed-off-by: Storvold, Sverre <[email protected]>
Signed-off-by: Storvold, Sverre <[email protected]>
@Blackladder Blackladder closed this Jul 2, 2019
@Blackladder Blackladder reopened this Jul 2, 2019
@Blackladder Blackladder closed this Jul 2, 2019
@joerchan
Copy link
Contributor

joerchan commented Jul 2, 2019

PR re-opened in #17246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: API Changes to public APIs area: Bluetooth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants