-
Notifications
You must be signed in to change notification settings - Fork 8.2k
tests: kernel: submit a simple test for zero-latency irqs #17045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: kernel: submit a simple test for zero-latency irqs #17045
Conversation
|
All checks are passing now. Review history of this comment for details about previous failed status. |
aa82340 to
2fef862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it split into two files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose, I just followed the arm_irq_vector_table test structure
2fef862 to
6c0ab49
Compare
|
@cvinayak could you also take a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
24b2869 to
14c6700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment as to why GetEnableIRQ() allows you to find an available interrupt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like what we have in line 22?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or a more detailed comment, e.g.
/*
* Interrupts configured statically with IRQ_CONNECT(..) are automatically enabled. NVIC_GetEnableIRQ() returning
* false implies that the IRQ line is not currently in use by Zephyr.
*/
14c6700 to
fb7f9da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me
The commit contributes a simple test for the Zero-Latency IRQ feature (CONFIG_ZERO_LATENCY_IRQS=y) for ARM platforms. Signed-off-by: Ioannis Glaropoulos <[email protected]>
Add the arm tag to tests/kernel/arm_runtime_nmi test. Signed-off-by: Ioannis Glaropoulos <[email protected]>
fb7f9da to
b95a719
Compare
Fixes #16901
The commit contributes a simple test for the Zero-Latency
IRQ feature (CONFIG_ZERO_LATENCY_IRQS=y) for ARM platforms.
Signed-off-by: Ioannis Glaropoulos [email protected]