Skip to content

Conversation

@ioannisg
Copy link
Member

In ARM architecture z_priv_stack_find() returns the start of a
thread's privilege stack; we do not need to subtract the length
of a (possible) stack guard. This commit corrects the assigning
of the start address of a thread privilege stack in
test/kerne/mem_protect/mem_protect/userspace.

Signed-off-by: Ioannis Glaropoulos [email protected]

@ioannisg ioannisg requested review from andrewboie and wentongwu June 14, 2019 10:40
@ioannisg ioannisg requested review from andyross and nashif as code owners June 14, 2019 10:40
@ioannisg ioannisg added area: Memory Protection Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. area: Tests Issues related to a particular existing or missing test area: Userspace Userspace labels Jun 14, 2019
@ioannisg
Copy link
Member Author

Tested on all 3 MPU variants of ARM (v7m, v8m, nxp); test is passing

@ioannisg ioannisg added the bug The issue is a bug, or the PR is fixing a bug label Jun 14, 2019
@ioannisg
Copy link
Member Author

recheck

In ARM architecture z_priv_stack_find() returns the start of a
thread's privilege stack; we do not need to subtract the length
of a (possible) stack guard. This commit corrects the assigning
of the start address of a thread privilege stack in
test/kerne/mem_protect/mem_protect/userspace.

Signed-off-by: Ioannis Glaropoulos <[email protected]>
@ioannisg ioannisg force-pushed the tests_userspace_fix_priv_stack_start branch from dc78ba9 to 8184af1 Compare June 17, 2019 07:47
@andrewboie andrewboie merged commit 02a3c52 into zephyrproject-rtos:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Kernel area: Memory Protection area: Tests Issues related to a particular existing or missing test area: Userspace Userspace bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants