arch: arm: fix start of MPU guard in stack-fail check (no user mode) #16757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
added
bug
|
I would back-port that to 1.14.1 |
ioannisg
force-pushed
the
arch_arm_mpu_fix_guard_limit_no_usermode
branch
from
235d499 to
0f97fe4
Compare
andrewboie
approved these changes
Jun 11, 2019
|
@ioannisg if this is going into 1.14.1, please create a bug |
When building without support for user mode (CONFIG_USERSPACE=n) we need to correct the starting address of the MPU Guard, before passing it to the function that evaluates whether a stack corruption has occurred. The bug was introduced by commit (60bae5d) in PR-13619, where the start address of the MPU guard was properly corrected, but the guard start at the corresponding stack-fail check was not adjusted accordingly. Signed-off-by: Ioannis Glaropoulos <[email protected]>
ioannisg
force-pushed
the
arch_arm_mpu_fix_guard_limit_no_usermode
branch
from
0f97fe4 to
a6c834e
Compare
@nashif @MaureenHelm , pls, take a look at the associated bug report: #16779 |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building without support for user mode (CONFIG_USERSPACE=n)
we need to correct the starting address of the MPU Guard, before
passing it to the function that evaluates whether a stack
corruption has occurred. The bug was introduced by 60bae5d in
#13619, where the start address of the MPU guard was properly
corrected, but the guard start at the corresponding stack-fail
check was not adjusted accordingly.
Signed-off-by: Ioannis Glaropoulos [email protected]