Arch arm main thread init cleanup #16382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For architectures with custom swap to main, currently: - arm - posix we are now using K_THREAD_STACK_SIZEOF macro to pass the main thread stack size to z_arch_switch_to_main_thread(). This does not introduce any behavioral changes for posix; the K_THREAD_STACK_SIZEOF() simply returns the sizeof() the stack object. For Arm, this allows us to clean-up one more occurence of CONFIG_MPU_REQUIRES_POWER_OF_TWO_ALIGNMENT in kernel_arch_func.h. Signed-off-by: Ioannis Glaropoulos <[email protected]>
ioannisg
requested review from
MaureenHelm,
andrewboie,
andyross and
galak
as code owners
ioannisg
added
area: Kernel
area: ARM
26 tasks
aescolar
reviewed
May 24, 2019
Remove a redundant #ifdef CONFIG_MULTITHREADING guard for a code block already inside CONFIG_MULTITHREADING. Add some inline #endif comments for ease of reading. Signed-off-by: Ioannis Glaropoulos <[email protected]>
ioannisg
force-pushed
the
arch_arm_main_thread_init_cleanup
branch
from
cec293d to
bf28d41
Compare
fixed |
nashif
approved these changes
May 24, 2019
andyross
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches for kernel/init.c
It's a cleanup - no behavioral changes.