ipc: openamp: Expose config options for MASTER/SLAVE builds #14750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14750 +/- ##
==========================================
+ Coverage 52.5% 52.5% +<.01%
==========================================
Files 309 309
Lines 45046 45047 +1
Branches 10417 10418 +1
==========================================
+ Hits 23653 23654 +1
- Misses 16585 16586 +1
+ Partials 4808 4807 -1
Continue to review full report at Codecov.
|
arnopo
requested changes
Jul 29, 2019
Contributor
Author
|
Updated open-amp module in this pr zephyrproject-rtos/open-amp#5 |
We can build the openamp library configured with VirtIO master support, VirtIO slave support, or both. By default both master and slave code is enabled. We can reduce code footprint by only build master or slave as needed. Expose Kconfig options for Master & Slave and set them accordingly in the sample. Here's the code reduction we see: For the total image we see as 1260 byte reduction: Memory region Used Size Region Size %age Used FLASH [Master & Slave]: 30308 B 256 KB 11.56% FLASH [Master only] : 29048 B 256 KB 11.08% On the remote side we see a 828 byte reduction: Memory region Used Size Region Size %age Used FLASH [Master & Slave]: 11564 B 64 KB 17.65% FLASH [Slave only] : 10736 B 64 KB 16.38% Signed-off-by: Kumar Gala <[email protected]>
arnopo
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can build the openamp library configured with VirtIO master
support, VirtIO slave support, or both. By default both master
and slave code is enabled. We can reduce code footprint by only
build master or slave as needed.
Expose Kconfig options for Master & Slave and set them accordingly in
the sample.
Here's the code reduction we see:
For the total image we see as 1260 byte reduction:
Memory region Used Size Region Size %age Used
FLASH [Master & Slave]: 30308 B 256 KB 11.56%
FLASH [Master only] : 29048 B 256 KB 11.08%
On the remote side we see a 828 byte reduction:
Memory region Used Size Region Size %age Used
FLASH [Master & Slave]: 11564 B 64 KB 17.65%
FLASH [Slave only] : 10736 B 64 KB 16.38%
Signed-off-by: Kumar Gala [email protected]