soc/samr21: Initial support #13494

benpicco · 2019-02-18T17:19:52Z

The samr21 is an ARM Cortex-M0 part very simmilar to the samd21, but comes with a on-chip radio (AT86RF233) connected internally via SPI.

This adds support for the SoC family and the SAM R21 Xplained Pro eveluation board.
Most of it is copy & paste from atmel_sam0/samd21.

The AT86RF233 radio is not supported yet at this point.

zephyrbot · 2019-02-18T17:22:49Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

codecov-io · 2019-02-18T18:07:39Z

Codecov Report

Merging #13494 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13494      +/-   ##
==========================================
+ Coverage   51.96%   51.99%   +0.03%     
==========================================
  Files         309      309              
  Lines       45576    45576              
  Branches    10554    10554              
==========================================
+ Hits        23683    23699      +16     
+ Misses      17083    17071      -12     
+ Partials     4810     4806       -4

Impacted Files	Coverage Δ
subsys/testsuite/ztest/src/ztest.c	`72.72% <0%> (+7.43%)`	⬆️
subsys/testsuite/ztest/include/ztest_assert.h	`77.77% <0%> (+38.88%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a546d1...18fa35d. Read the comment docs.

dbkinder

a few doc changes ...

boards/arm/atsamr21_xpro/doc/index.rst

mnkp · 2019-02-19T20:36:14Z

This PR looks good overall, thanks @benpicco, but it needs to be split in three parts:

ASF files provided by Atmel located in ext/
samr21 soc files located in soc/
atsamr21_xpro board support located in board/

The commit messages have to follow documentation guidelines Identifying Contribution Origin.

The header files provided by Atmel often have mixed line endings. We should change them to the Unix '\n'. Otherwise the first commit shouldn't contain any modifications to the original files.

dbkinder

+1 for doc changes, thanks!

mnkp

There are several minor issues. Overall it looks good.

One thing which needs to be globally fixed are copyright headers. You'll need to include your name there. I'm only not sure what should happen with the name of the original author. @nashif or @galak should know.

soc/arm/atmel_sam0/samr21/Kconfig.series

soc/arm/atmel_sam0/samr21/Kconfig.soc

soc/arm/atmel_sam0/samr21/CMakeLists.txt

soc/arm/atmel_sam0/samr21/soc.c

soc/arm/atmel_sam0/samr21/soc.h

boards/arm/atsamr21_xpro/atsamr21_xpro_defconfig

boards/arm/atsamr21_xpro/doc/index.rst

mnkp

Power management system has been recently updated. As you probably have noticed by now this PR needs to be rebased on top of the latest master.

soc/arm/atmel_sam0/samr21/soc.h

boards/arm/atsamr21_xpro/atsamr21_xpro.dts

boards/arm/atsamr21_xpro/atsamr21_xpro_defconfig

soc/arm/atmel_sam0/common/soc_power.c

mnkp

LGTM with minor comments.

Unfortunately, there is an ongoing work regarding Power Management API (#13632) which will break current implemenation. When #13632 is merged one will need to run a few string replacement operations in soc/arm/atmel_sam0/common/power.c.

soc/arm/atmel_sam0/common/Kconfig.defconfig.series

mnkp · 2019-02-23T21:33:33Z

soc/arm/atmel_sam0/common/power.h

@@ -0,0 +1,35 @@
+/*


This file is no longer necessary and can be removed. Functions declarations are available via include/power.h.

removed it.

It looks like soc/arm/atmel_sam0/common/power.h is still present in this PR.

oops, sorry - I hope I didn't miss anything else, but I think here I just used rm instead of git rm and forgot to commit it.

benpicco · 2019-03-06T12:29:54Z

@mnkp I replaced the strings with their new versions from #13632

The rest of the changes should be addressed now too.

benpicco · 2019-03-12T13:18:57Z

Once #14005 #13717 and #14128 are merged they can be enabled here as well.

mnkp

@benpicco Sorry for a delay, I was busy. LGTM but some things have not yet been fixed. Maybe you didn't push all the local changes you did?

Also a minor thing, the "soc: atmel: auto-select peripherals on SAM0" could be squashed with "soc: atmel: add SAMR21" as it logically belongs there.

mnkp · 2019-03-12T21:53:21Z

soc/arm/atmel_sam0/common/power.h

@@ -0,0 +1,35 @@
+/*


It looks like soc/arm/atmel_sam0/common/power.h is still present in this PR.

jfischer-no · 2019-04-17T17:26:37Z

boards/arm/atsamr21_xpro/atsamr21_xpro.yaml

(at least gpio and usb, i2c?)

supported: - gpio - usb_device

I'll add gpio & usb - i2c depends on #14128

Ah turns out this makes CI build some more projects with the board!
The build failure should be fixed by #14832 then. I'd rather have this merged first than manually enabling the driver implementations to the board default config.

It still fails!
#15584 should fix this 🤞

mnkp · 2019-04-22T19:19:12Z

soc/arm/atmel_sam0/common/CMakeLists.txt

Maybe we should write it as

zephyr_sources_ifdef( (CONFIG_SOC_SERIES_SAMD20 OR CONFIG_SOC_SERIES_SAMD21 OR CONFIG_SOC_SERIES_SAMR21) soc_samd2x.c)

If I write it like that, soc_samd2x.c does not get build.

Atmel Software Framework (ASF) provides a set of low-level header files that give access to different hardware peripherals of Atmel's ICs. Origin: Atmel SAMR21 Series Device Support (1.1.72) License: Apache-2.0 URL: http://packs.download.atmel.com/Atmel.SAMR21_DFP.1.1.72.atpack Purpose: Introduction of ASF for the SAM0 series. Maintained-by: External Signed-off-by: Benjamin Valentin <[email protected]>

Adds Atmel SAMR21 soc which is based on SAMD21, but with a AT86RF233 radio connected internally via SPI. The AT86RF233 is not yet supprted by Zephyr at this point. This code is very much copy & paste from atmel_sam0/samd21 Signed-off-by: Benjamin Valentin <[email protected]>

Add the Atmel SAM R21 Xplained Pro Evaluation Kit to zephyr. So far, UART, SPI, I2C (depends on zephyrproject-rtos#14128), debug LED and user button have been tested. Signed-off-by: Benjamin Valentin <[email protected]>

Take ownership of external SDK files. Signed-off-by: Benjamin Valentin <[email protected]>

The Atmel SAMD21 (and therefore also the SAMR21) comes with the same RTC peripheral as the Atmel SAMD20. Enable it in dts_fixup.h and enable it in the dts for samr21_xpro. Signed-off-by: Benjamin Valentin <[email protected]>

The init routines are the same for SAMD20, SAMD21 and SAMR21, so move them into common/ to not have three copies of the same code. Signed-off-by: Benjamin Valentin <[email protected]>

benpicco requested review from MaureenHelm, dbkinder and galak as code owners February 18, 2019 17:19

benpicco force-pushed the samr21 branch from 88ddb69 to bdeac68 Compare February 18, 2019 17:30

benpicco force-pushed the samr21 branch from bdeac68 to a1e3b30 Compare February 19, 2019 09:47

galak requested a review from mnkp February 19, 2019 14:23

dbkinder suggested changes Feb 19, 2019

View reviewed changes

boards/arm/atsamr21_xpro/doc/index.rst Outdated Show resolved Hide resolved

boards/arm/atsamr21_xpro/doc/index.rst Outdated Show resolved Hide resolved

boards/arm/atsamr21_xpro/doc/index.rst Outdated Show resolved Hide resolved

dbkinder approved these changes Feb 19, 2019

View reviewed changes

benpicco force-pushed the samr21 branch from 3f08af8 to 26ee204 Compare February 19, 2019 22:21

mnkp requested changes Feb 19, 2019

View reviewed changes

benpicco force-pushed the samr21 branch from 26ee204 to 56e8801 Compare February 20, 2019 18:40

mnkp reviewed Feb 21, 2019

View reviewed changes

benpicco force-pushed the samr21 branch 5 times, most recently from 0eac4ef to a5fe7b5 Compare February 22, 2019 17:29

mnkp reviewed Feb 23, 2019

View reviewed changes

benpicco force-pushed the samr21 branch 2 times, most recently from 944b98d to 0a9091e Compare February 28, 2019 12:40

benpicco force-pushed the samr21 branch 2 times, most recently from a47eae9 to bb93263 Compare March 6, 2019 10:42

mnkp reviewed Mar 12, 2019

View reviewed changes

benpicco force-pushed the samr21 branch 2 times, most recently from 43bdc86 to b28b2db Compare March 12, 2019 22:43

benpicco force-pushed the samr21 branch 6 times, most recently from e1d887f to bc66a08 Compare April 9, 2019 13:44

jfischer-no reviewed Apr 17, 2019

View reviewed changes

benpicco force-pushed the samr21 branch 3 times, most recently from 4f25db5 to f14d077 Compare April 18, 2019 10:18

benpicco requested a review from tbursztyka as a code owner April 18, 2019 10:18

galak force-pushed the samr21 branch from f14d077 to 999c9b5 Compare April 19, 2019 18:42

benpicco force-pushed the samr21 branch from 999c9b5 to 670d2de Compare April 20, 2019 09:36

benpicco mentioned this pull request Apr 20, 2019

usb: sam0: implement missing API functions for tests/subsys/usb/device #15584

Merged

mnkp reviewed Apr 22, 2019

View reviewed changes

benpicco force-pushed the samr21 branch from b3cae82 to 7d334a7 Compare April 24, 2019 22:38

galak force-pushed the samr21 branch from 7d334a7 to fe56119 Compare April 26, 2019 10:51

galak force-pushed the samr21 branch 2 times, most recently from b8eb0d1 to 53cc42f Compare April 26, 2019 11:10

benpicco and others added 5 commits April 26, 2019 14:59

boards: atsamr21_xpro: Add SAM R21 Xplained Pro Evaluation Kit

1acaa53

Add the Atmel SAM R21 Xplained Pro Evaluation Kit to zephyr. So far, UART, SPI, I2C (depends on zephyrproject-rtos#14128), debug LED and user button have been tested. Signed-off-by: Benjamin Valentin <[email protected]>

CODEOWNERS: Add code ownership for Atmel samr21 code

7aec6f3

Take ownership of external SDK files. Signed-off-by: Benjamin Valentin <[email protected]>

soc: sam0: enable RTC for samd21, samr21

bf44615

The Atmel SAMD21 (and therefore also the SAMR21) comes with the same RTC peripheral as the Atmel SAMD20. Enable it in dts_fixup.h and enable it in the dts for samr21_xpro. Signed-off-by: Benjamin Valentin <[email protected]>

soc: sam0: Make init code common between all samd2x SoCs

58b91b4

The init routines are the same for SAMD20, SAMD21 and SAMR21, so move them into common/ to not have three copies of the same code. Signed-off-by: Benjamin Valentin <[email protected]>

benpicco force-pushed the samr21 branch from 53cc42f to 58b91b4 Compare April 26, 2019 13:00

nashif approved these changes Apr 28, 2019

View reviewed changes

nashif merged commit 86bd319 into zephyrproject-rtos:master Apr 28, 2019

benpicco deleted the samr21 branch April 28, 2019 17:27

KwonTae-young mentioned this pull request May 3, 2019

Support AT86RF233 #15841

Closed

soc/samr21: Initial support #13494

soc/samr21: Initial support #13494

Uh oh!

Conversation

benpicco commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnkp commented Feb 19, 2019

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benpicco commented Mar 6, 2019

Uh oh!

benpicco commented Mar 12, 2019

Uh oh!

mnkp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

benpicco commented Feb 18, 2019 •

edited

Loading

zephyrbot commented Feb 18, 2019 •

edited

Loading

codecov-io commented Feb 18, 2019 •

edited

Loading