mDNS client support #1341
Merged
mDNS client support #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lpereira
reviewed
Sep 7, 2017
subsys/net/lib/dns/resolve.c
Outdated
| const char *ptr = strstr(query, ".local"); | ||
|
|
||
| for (j = 0; j < CONFIG_DNS_RESOLVER_MAX_SERVERS; j++) { | ||
| if (ptr && !memcmp(ptr, (const void *){ ".local\0" }, 7)) { |
There was a problem hiding this comment.
Minimal libc has a strrchr() function: search for the last dot, and memcmp() the returned ptr with ".local". It should be faster than using strstr() which is quadratic in the minimal libc.
This implements mDNS client from RFC 6762. What this means that caller is able to resolve "hostname.local" names using multicast DNS. Signed-off-by: Jukka Rissanen <[email protected]>
The DNS resolver example enables mDNS client support and then queries zephyr.local hostname. The net-tools project has example avahi-daemon script that will response these .local queries and can be used in testing. Signed-off-by: Jukka Rissanen <[email protected]>
The IPv4 multicast address to MAC address mapping was missing the 4th byte high bit clearing. We also need to have some storage for the multicast MAC address. This was missing which could cause NULL pointer access. Signed-off-by: Jukka Rissanen <[email protected]>
|
New version uploaded with suggested changes from @lpereira |
nashif
approved these changes
Sep 17, 2017
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
Signed-off-by: Cui Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.