arch: posix: posix_cheats: Improve it #13068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to rename the POSIX types, so let's not do it to simplify things Also remove an unnecessary guard (POSIX_ARCH) to avoid mystifying this any more than necessary Related to zephyrproject-rtos#13054 Signed-off-by: Alberto Escolar Piedras <[email protected]>
Member
Author
|
@pfalcon : Is this improving things a bit? |
Codecov Report
@@ Coverage Diff @@
## master #13068 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 313 313
Lines 46436 46436
Branches 10710 10710
=======================================
Hits 22585 22585
Misses 19395 19395
Partials 4456 4456Continue to review full report at Codecov.
|
pfalcon
reviewed
Feb 5, 2019
Add a few comments in posix_cheats.h explaining why the file exists and how it is used. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
force-pushed
the
posix_cheats_improv
branch
from
8404a5b to
f5faeae
Compare
nashif
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few comments in posix_cheats.h explaining why the file exists and how it is used.
There is no need to rename the POSIX types, so let's not do it to simplify things
Also remove an unnecessary guard (POSIX_ARCH) to avoid mystifying this any more than necessary
Related to #13054