Revert "Implement net_context locking" #12922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
added
the
Hotfix
This reverts commit 93e5181. The commit causes failure on the following tests: qemu_x86: tests/net/lib/dns_resolve/net.dns tests/net/lib/dns_resolve/net.dns.no_ipv6 Signed-off-by: Kumar Gala <[email protected]>
This reverts commit 34b07b9. Revert is related to previous commit revision. Signed-off-by: Kumar Gala <[email protected]>
galak
force-pushed
the
revert-8674-net-locking
branch
from
a1144ba to
9689c65
Compare
tbursztyka
requested changes
Jan 31, 2019
Contributor
tbursztyka
left a comment
tbursztyka
left a comment
There was a problem hiding this comment.
Let's not revert: it is a necessary patch. Let's fix the bug it introduced instead.
Contributor
Author
I'm fine w/that, just need a quick solution since this breaks CI for everyone! |
Contributor
|
@galak Let's say if we don't get a solution in ~2h, you'll be able to push your revert? |
|
Found the following issues, please fix and resubmit: identity/email issuesccbbea304a92b801cccd48d00f96ba4d16ec30fe: author email (Kumar Gala [email protected]) needs to match one of the signed-off-by entries. |
Member
|
Actually the tests pass, it is just that at the end there is a crash. Investigating... |
Member
|
I have a "fix" proposal at #12926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8674
This seems to break CI right now as there are failures in: