Skip to content

Conversation

@cvinayak
Copy link
Contributor

Include building the init tests with the new Link Layer
split architecture.

Has the data length update and controller privacy disabled
until they are implemented in the new architecture.

Signed-off-by: Vinayak Kariappa Chettimada [email protected]

@carlescufi carlescufi requested a review from aescolar January 24, 2019 14:20
@aescolar
Copy link
Member

@cvinayak : Would it make sense to add a pair also to run in simulation? (meaning a new tests/bluetooth/bsim_bt/bsim_test_app/prj.conf + scripts in here: tests/bluetooth/bsim_bt/bsim_test_app/tests_scripts )

@aescolar
Copy link
Member

@cvinayak : Note that the CI failure seems genuine:
nrf51_pca10028/tests/bluetooth/init/test_controller_ll_sw_split
prj_controller_ll_sw_split.conf:3: warning: attempt to assign the value 'y' to the undefined symbol BT_CTLR_LL_SW_SPLIT

@cvinayak
Copy link
Contributor Author

@aescolar yes, typo in the define, will fix it (atleast I now know CI is building the added test!)

Include building the init tests with the new Link Layer
split architecture.

Has the data length update and controller privacy disabled
until they are implemented in the new architecture.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #12689 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12689   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         243      243           
  Lines       27768    27768           
  Branches     6749     6749           
=======================================
  Hits        14958    14958           
  Misses      10002    10002           
  Partials     2808     2808

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e098a...cd68ed2. Read the comment docs.

@carlescufi carlescufi mentioned this pull request Jan 25, 2019
6 tasks
@jhedberg jhedberg merged commit 1d47030 into zephyrproject-rtos:master Jan 25, 2019
@cvinayak cvinayak deleted the github_ll_split_ci branch March 1, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants