drivers: nrf: Add UART and UARTE configure function. #11577

Mierunski · 2018-11-21T13:56:53Z

Add UART configure function for UART and UARTE shims.

Signed-off-by: Mieszko Mierunski [email protected]

codecov-io · 2018-11-21T15:50:59Z

Codecov Report

Merging #11577 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11577   +/-   ##
=======================================
  Coverage   48.21%   48.21%           
=======================================
  Files         279      279           
  Lines       43303    43303           
  Branches    10370    10370           
=======================================
  Hits        20878    20878           
  Misses      18279    18279           
  Partials     4146     4146

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb68ac6...e5bf097. Read the comment docs.

drivers/serial/uart_nrfx_uart.c

drivers/serial/uart_nrfx_uarte.c

Mierunski · 2018-11-26T10:31:13Z

@anangl All should be fixed now

drivers/serial/uart_nrfx_uart.c

drivers/serial/uart_nrfx_uarte.c

drivers/serial/uart_nrfx_uart.c

Mierunski · 2018-11-29T07:59:06Z

@anangl Fixed

anangl

Almost there. A few minor corrections needed.

drivers/serial/uart_nrfx_uarte.c

Add UART configure function for UART and UARTE shims. Signed-off-by: Mieszko Mierunski <[email protected]>

anangl

Beautiful. As much as it was possible. ;-)
Thanks for your tenacity.

jakub-uC

Minor change proposals -not a merge blocker.

jakub-uC · 2018-11-29T12:39:15Z

drivers/serial/uart_nrfx_uart.c

+	}
+
+	if (baudrate_set(dev, cfg->baudrate) != 0) {
+		return -ENOTSUP;


I think that value -EINVAL is better here.

API specifies that -ENOTSUP will be returned if configuration is not supported by driver. Same applies to other places

jakub-uC · 2018-11-29T12:40:00Z

drivers/serial/uart_nrfx_uart.c

+		parity = NRF_UART_PARITY_INCLUDED;
+		break;
+	default:
+		return -ENOTSUP;


jakub-uC · 2018-11-29T12:43:48Z

drivers/serial/uart_nrfx_uart.c

-#ifndef DT_NORDIC_NRF_UART_UART_0_CTS_PIN
-#error Flow control for UART0 is enabled, but CTS pin is not defined.
-#endif
+#if	defined(DT_NORDIC_NRF_UART_UART_0_RTS_PIN) && \


Please use IS_ENABLED macro.

Functions called in lines below use value of this define, I can use #if with IS_ENABLED but I don't think it will improve anything. Using if() is not possible here

jakub-uC · 2018-11-29T12:49:35Z

drivers/serial/uart_nrfx_uarte.c

+		}
+		break;
+	default:
+		return -ENOTSUP;


jakub-uC · 2018-11-29T12:49:52Z

drivers/serial/uart_nrfx_uarte.c

+	}
+
+	if (baudrate_set(dev, cfg->baudrate) != 0) {
+		return -ENOTSUP;


Mierunski · 2018-11-29T13:54:04Z

@carlescufi Please take a look

Mierunski added area: Drivers platform: nRF Nordic nRFx labels Nov 21, 2018

Mierunski requested review from anangl, carlescufi and jakub-uC November 21, 2018 13:56

Mierunski force-pushed the nrf_uart_configure branch from 6a8a597 to f16d3fa Compare November 21, 2018 14:44

pfalcon mentioned this pull request Nov 22, 2018

api: uart: Add configure functions for UART. #11185

Merged

jakub-uC added the area: UART Universal Asynchronous Receiver-Transmitter label Nov 22, 2018

Mierunski force-pushed the nrf_uart_configure branch from f16d3fa to 31ea7cb Compare November 22, 2018 08:43

anangl requested changes Nov 22, 2018

View reviewed changes

Mierunski force-pushed the nrf_uart_configure branch 4 times, most recently from 917e492 to 3e36b2f Compare November 23, 2018 14:06

zephyrproject-rtos deleted a comment from zephyrbot Nov 23, 2018

Mierunski force-pushed the nrf_uart_configure branch 2 times, most recently from 20b7aea to 2a46ae6 Compare November 26, 2018 08:42

Mierunski force-pushed the nrf_uart_configure branch 3 times, most recently from 901d7b8 to 1342b9c Compare November 28, 2018 08:34

anangl reviewed Nov 28, 2018

View reviewed changes

Mierunski force-pushed the nrf_uart_configure branch 2 times, most recently from 367c564 to 198391e Compare November 28, 2018 13:20

anangl reviewed Nov 29, 2018

View reviewed changes

drivers: nrf: Add UART and UARTE configure function.

e5bf097

Add UART configure function for UART and UARTE shims. Signed-off-by: Mieszko Mierunski <[email protected]>

Mierunski force-pushed the nrf_uart_configure branch from 198391e to e5bf097 Compare November 29, 2018 09:34

anangl approved these changes Nov 29, 2018

View reviewed changes

jakub-uC reviewed Nov 29, 2018

View reviewed changes

jakub-uC approved these changes Nov 29, 2018

View reviewed changes

carlescufi approved these changes Nov 29, 2018

View reviewed changes

carlescufi merged commit 94b72e7 into zephyrproject-rtos:master Nov 29, 2018

Mierunski deleted the nrf_uart_configure branch November 29, 2018 14:07

drivers: nrf: Add UART and UARTE configure function. #11577

drivers: nrf: Add UART and UARTE configure function. #11577

Uh oh!

Conversation

Mierunski commented Nov 21, 2018

Uh oh!

codecov-io commented Nov 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mierunski commented Nov 26, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mierunski commented Nov 29, 2018

Uh oh!

anangl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anangl left a comment

Choose a reason for hiding this comment

Uh oh!

jakub-uC left a comment

Choose a reason for hiding this comment

Uh oh!

jakub-uC Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

Mierunski Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jakub-uC Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jakub-uC Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

Mierunski Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jakub-uC Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

jakub-uC Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

Mierunski commented Nov 29, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-io commented Nov 21, 2018 •

edited

Loading