Skip to content

Conversation

@nordic-krch
Copy link
Contributor

@nordic-krch nordic-krch commented Nov 16, 2018

RTT and uart shell backends were started with fixed
log limit set to INF. Configuration has been moved
to Kconfig allowing certain level or default LOG_MAX_LEVEL.

Fixes #11417.

Signed-off-by: Krzysztof Chruscinski [email protected]

@codecov-io
Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #11434 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11434      +/-   ##
==========================================
- Coverage   48.38%   48.29%   -0.09%     
==========================================
  Files         265      265              
  Lines       42193    42180      -13     
  Branches    10137    10136       -1     
==========================================
- Hits        20413    20371      -42     
- Misses      17703    17728      +25     
- Partials     4077     4081       +4
Impacted Files Coverage Δ
subsys/logging/log_output.c 63.59% <0%> (-8.74%) ⬇️
subsys/logging/log_core.c 71.1% <0%> (-3.47%) ⬇️
misc/printk.c 85.45% <0%> (-3.1%) ⬇️
include/logging/log_msg.h 89.09% <0%> (-1.82%) ⬇️
include/logging/log_core.h 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644b31d...492a49e. Read the comment docs.

@pfalcon
Copy link
Contributor

pfalcon commented Nov 16, 2018

Confirmed this fixes #11417, why not list it as "Fixes:" in the commit message?

And I tried to dig into fixing that myself, couldn't find much except workaround of CONFIG_LOG_RUNTIME_FILTERING=n (which is not so easy to apply), and wouldn't imagine it has something to do with logging backends...

Copy link
Contributor

@pfalcon pfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #11417 which blocks networking debugging.

@pfalcon
Copy link
Contributor

pfalcon commented Nov 16, 2018

There's a bunch of checkpatch errors, should be easy to fix.

Thanks for quick fix btw!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's for example trailing whitespace (on otherwise empty line) about which checkpatch complains (and on bunch of other lines too).

RTT and uart shell backends were started with fixed
log limit set to INF. Configuration has been moved
to Kconfig allowing certain level or default LOG_MAX_LEVEL.

Signed-off-by: Krzysztof Chruscinski <[email protected]>
@jakub-uC jakub-uC requested a review from carlescufi November 19, 2018 10:53
@jakub-uC
Copy link
Contributor

@carlescufi : May you please merge this fix?

@carlescufi carlescufi merged commit 8421543 into zephyrproject-rtos:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logging doesn't log, again

5 participants