-
Notifications
You must be signed in to change notification settings - Fork 8.2k
shell: Add initial log level for rtt and uart backends #11434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell: Add initial log level for rtt and uart backends #11434
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11434 +/- ##
==========================================
- Coverage 48.38% 48.29% -0.09%
==========================================
Files 265 265
Lines 42193 42180 -13
Branches 10137 10136 -1
==========================================
- Hits 20413 20371 -42
- Misses 17703 17728 +25
- Partials 4077 4081 +4
Continue to review full report at Codecov.
|
|
Confirmed this fixes #11417, why not list it as "Fixes:" in the commit message? And I tried to dig into fixing that myself, couldn't find much except workaround of CONFIG_LOG_RUNTIME_FILTERING=n (which is not so easy to apply), and wouldn't imagine it has something to do with logging backends... |
pfalcon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #11417 which blocks networking debugging.
|
There's a bunch of checkpatch errors, should be easy to fix. Thanks for quick fix btw! |
subsys/shell/Kconfig.backends
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's for example trailing whitespace (on otherwise empty line) about which checkpatch complains (and on bunch of other lines too).
RTT and uart shell backends were started with fixed log limit set to INF. Configuration has been moved to Kconfig allowing certain level or default LOG_MAX_LEVEL. Signed-off-by: Krzysztof Chruscinski <[email protected]>
d978eb8 to
492a49e
Compare
|
@carlescufi : May you please merge this fix? |
RTT and uart shell backends were started with fixed
log limit set to INF. Configuration has been moved
to Kconfig allowing certain level or default LOG_MAX_LEVEL.
Fixes #11417.
Signed-off-by: Krzysztof Chruscinski [email protected]