Misc net fixes #1093
Merged
Misc net fixes #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user has not specified CONFIG_NET_APP_MY_IPV4_ADDR or CONFIG_NET_APP_MY_IPV6_ADDR, the value is set to "" in this case. This will be converted to ANY IP address which is not useful to be set to the network interface. So check this and just continue the init in this case without setting the IP address. Signed-off-by: Jukka Rissanen <[email protected]>
This is needed so that we can get L2 information for example in net-shell. Signed-off-by: Jukka Rissanen <[email protected]>
When printing network interface specific data, print also the type of the network interface (ethernet, bluetooth etc). Signed-off-by: Jukka Rissanen <[email protected]>
The parent output strings were incorrectly aligned. Signed-off-by: Jukka Rissanen <[email protected]>
Print network interface where the DIO, DIS or DAO was sent. This is useful if we have multiple network interfaces in the system. Signed-off-by: Jukka Rissanen <[email protected]>
Allow user to define what kind of network the RPL should serve. Currently options will be either ANY or IEEE802154. If there is only one network interface in the system, then ANY will take the default network interface and use that. If there are multiple network interfaces, then one should not use ANY as the default network interface might not be the expected one. Signed-off-by: Jukka Rissanen <[email protected]>
This is only usable in the root node. Signed-off-by: Jukka Rissanen <[email protected]>
tbursztyka
requested changes
Aug 14, 2017
subsys/net/ip/nbr.h
Outdated
There was a problem hiding this comment.
can you move it after 'clear' attribute?
There was a problem hiding this comment.
Sure, ordering does not really matter currently in the struct but if we need to add more items then it is useful to have the count as a last member.
Instead of always having CONFIG_NET_IPV6_MAX_NEIGHBORS number of items in neighbor pool, store the neighbor count in the pool and use that value when traversing the neighbor table. Signed-off-by: Jukka Rissanen <[email protected]>
Instead of always have CONFIG_NET_IPV6_MAX_NEIGHBORS parents, use CONFIG_NET_RPL_MAX_PARENTS when creating the parent table. Default value for max parents is the max neighbors so no functionality changes are introduced here. Signed-off-by: Jukka Rissanen <[email protected]>
Instead of printing [net/net_pkt], print [net/pkt] if debug log is enabled for network packet allocator. The double net in earlier print is redundant information. Signed-off-by: Jukka Rissanen <[email protected]>
This is needed in order to get information which function is doing the ref. With inline function this was not possible. Signed-off-by: Jukka Rissanen <[email protected]>
|
Updated according to comment. |
tbursztyka
approved these changes
Aug 14, 2017
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
Fixes zephyrproject-rtos#1091 Signed-off-by: James Prestwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to various part of the IP stack while working on #980