Skip to content

[RFC] logging: Default to redirecting printk() through it #10715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[RFC] logging: Default to redirecting printk() through it #10715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32dc5a
logging: Default to redirecting printk() through it
carlescufi Oct 19, 2018
876dcdd
tests: kernel: printk: Disable deferred printk handling
carlescufi Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions subsys/logging/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ config LOG_MAX_LEVEL

config LOG_PRINTK
bool "Enable processing of printk messages."
default y
Copy link
Contributor

@jakub-uC jakub-uC Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ugly clash with shell when boot banner is enabled :/.

Copy link
Contributor

@nordic-krch nordic-krch Oct 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shouldn't. That has been fixed with #10510

help
LOG_PRINTK messages are formatted in place and logged unconditionally.

Expand Down
1 change: 1 addition & 0 deletions tests/kernel/common/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
CONFIG_ZTEST=y
CONFIG_PRINTK=y
CONFIG_LOG=y
CONFIG_LOG_PRINTK=n
CONFIG_POLL=y