dts: Provide analog configuration for each pin #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarull
approved these changes
Dec 14, 2021
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
LGTM, just one comment regarding the lp variant.
I'd also remove mentions to low-power here:
hal_stm32/scripts/genpinctrl/stm32-pinctrl-config.yaml
Lines 30 to 32 in 161c4b2
erwango
force-pushed
the
dev_lp_analog_pin
branch
2 times, most recently
from
49b41da to
4567818
Compare
In a majority of cases low power pin configuration would be analog. Instead of providing a analog variant for each signal, which would be equivalent between each signal, generate analog variant for each pin supporting it. Signed-off-by: Erwan Gouriou <[email protected]>
Batch of -pinctrl.dtsi providing analog_lp_pxy configuration for each pin. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
dev_lp_analog_pin
branch
from
4567818 to
95ee884
Compare
ABOSTM
approved these changes
Mar 21, 2022
erwango
changed the title
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update generation script to provide analog configuration for each pin.
This configuration could be used as low power pin configuration, when possible.