Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2016

$this->setFieldValue($value);
}

public function setFieldValue($value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a setFieldValue() function is considered a new feature and it should be done with a new PR.

@ezimuel
Copy link
Contributor

ezimuel commented Aug 3, 2016

@DCMNMarc As I wrote in specific comments this PR should focus only on fixing #26. The other changes that you proposed should be done in a new PR as new feature. Thanks for your contribution!

Note: to fix #26 is enough to change this in constructor:

if ($value !== null) {
...

@ezimuel
Copy link
Contributor

ezimuel commented Aug 8, 2016

@DCMNMarc I fixed #26 issue with PR #87. Now, if you want you can focus on the new features proposed in this PR. Thanks again!

@ezimuel
Copy link
Contributor

ezimuel commented Aug 8, 2016

Closing this PR in favor of a new one @DCMNMarc.

@ezimuel ezimuel closed this Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Content-Length" header set to "0" returns header line without value
2 participants