feat(dropdowns): add navigation link support to Menu's Item component
#2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… george/menu-links # Conflicts: # packages/dropdowns/src/elements/menu/Item.tsx # packages/dropdowns/src/views/combobox/StyledOption.ts # packages/dropdowns/src/views/menu/StyledItem.ts # packages/dropdowns/src/views/menu/StyledItemContent.ts # packages/dropdowns/src/views/menu/StyledItemIcon.ts
jzempel
requested changes
Apr 22, 2025
| isSelected, | ||
| icon, | ||
| isDisabled, | ||
| isExternal = true, |
There was a problem hiding this comment.
In keeping with the majority of Garden API, this should not default to true. Let's let devs be specific about this.
| @@ -286,10 +286,14 @@ export interface IItemProps extends Omit<LiHTMLAttributes<HTMLLIElement>, 'value | |||
| icon?: ReactElement; | |||
| /** Indicates that the item is not interactive */ | |||
| isDisabled?: boolean; | |||
| /** If the item is an anchor, opens the link externally */ | |||
There was a problem hiding this comment.
Suggested change
| /** If the item is an anchor, opens the link externally */ | |
| /** Opens the `href` externally */ |
Follow documentation grammar guidelines.
| as: 'a' | ||
| })` | ||
| direction: ${props => props.theme.rtl && 'rtl'}; | ||
| color: ${({ theme }) => getColor({ theme, variable: 'foreground.primary' })}; |
There was a problem hiding this comment.
At this point, there should be no visual differentiation between <Item> and <Item href>. So the styling here should be about resetting any potential <a> styling (color, underline, etc).
There was a problem hiding this comment.
Thanks for clarifying. I followed the design from George's branch but I'll update.
jzempel
reviewed
Apr 22, 2025
This was referenced Apr 28, 2025
4 tasks
|
Closing in favor of #2021. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Menu's
Itemcomponent by adding support for navigational links.Details
MenuItem:href: When provided, the menu item is rendered as an anchor.isExternal: Whentrue, adds appropriate attributes (target="_blank"andrel="noopener noreferrer") to external links.Checklist
npm start)?bedrock)