Handle zarr 3.1.0 #766
Open
Handle zarr 3.1.0 #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
===========================================
+ Coverage 99.96% 100.00% +0.03%
===========================================
Files 64 64
Lines 2789 2804 +15
===========================================
+ Hits 2788 2804 +16
+ Misses 1 0 -1
🚀 New features to boost your workflow:
|
dstansby
requested changes
Jul 19, 2025
| @@ -56,6 +58,23 @@ | |||
| CODEC_PREFIX = "numcodecs." | |||
|
|
|||
|
|
|||
| def from_zarr_dtype(dtype: Any) -> np.dtype: | |||
There was a problem hiding this comment.
Suggested change
| def from_zarr_dtype(dtype: Any) -> np.dtype: | |
| def _from_zarr_dtype(dtype: Any) -> np.dtype: |
| return dtype # pragma: no cover | ||
|
|
||
|
|
||
| def to_zarr_dtype(dtype: np.dtype) -> Any: |
There was a problem hiding this comment.
Suggested change
| def to_zarr_dtype(dtype: np.dtype) -> Any: | |
| def _to_zarr_dtype(dtype: np.dtype) -> Any: |
what's the easiest way to set up a test matrix that includes multiple zarr versions that can be run locally easily? Maybe we need to bite the bullet and bring in #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a data type adapter layer for
numcodecs.zarr3. Ensures that zarr data structures get the right data type.this hopefully fixes the breakage caused by the zarr 3.1 release.
TODO: