Tests passing #69
Open
Tests passing #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossaddison
commented
Sep 3, 2025
rossaddison
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️/❌ |
| Breaks BC? | ✔️/❌ |
| Fixed issues | comma-separated list of tickets # fixed by the PR, if any |
Bring into line with app rossaddison/invoice Upgrade error level to level 1
26th November 2024
- Due to the archiving of nov/jose-php, openId Connect, has been removed from this fork
to allow the use and testing of other clients such as:
Facebook, Google, Github, LinkedIn,
Live, Twitter, TwitterOAuth2,
VKontakt, and Yandex.
- This fork is being tested currently and is psalm level 1 statically built and tested only.
- 3 issue handlers are currently in the psalm.xml and can be removed independently to see relevant errors
by running e.g c:\wamp64\www\yii-auth-client\php ./vendor/bin/psalm
- A suitable php substitute will hopefully be introduced later for nov/jose-php.
co pilot suggested install rather than update Refer to: https://github.com/yiisoft/actions/blob/master/.github/workflows/roave-infection.yml stryker api key enabled using: https://dashboard.stryker-mutator.io/repos/rossaddison
GuzzleHttp\Client extends the ClientInterface.
1. Parse response contents 2. Use OAuthToken type to create a basic token shell. 3. Use OAuthToken->setParam to build parameters received from the response contents specific to the individual identityProvider e.g. Github. 4. A new getOauth2ReturnUrl function independent of Oauth1's getReturnUrl created. 5. OAuth2Test adjusted to reflect 4.
ERROR: NonInvariantDocblockPropertyType - src/Asset/AuthChoiceAsset.php:21:18 - Property Yiisoft\Yii\AuthClient\Asset\AuthChoiceAsset::$js has type array<array-key, mixed>, not invariant with Yiisoft\Assets\AssetBundle::$js of type array<array-key, string|type-alias(Yiisoft\Assets\AssetManager::JsFile)> (see https://psalm.dev/267) public array $js = [ ERROR: NonInvariantDocblockPropertyType - src/Asset/AuthChoiceStyleAsset.php:15:18 - Property Yiisoft\Yii\AuthClient\Asset\AuthChoiceStyleAsset::$css has type array<array-key, mixed>, not invariant with Yiisoft\Assets\AssetBundle::$css of type array<array-key, string|type-alias(Yiisoft\Assets\AssetManager::CssFile)> (see https://psalm.dev/267) public array $css = [
Auth, token, and endpoint Url's have been changed. No specific API is being used although a web application has been setup under console.cloud.google.com. The function parse_str has been improved to parse_str_clean to remove underscores that the parse_str function was generating.
MicrosoftOnline to replace deprecated Live. These are preliminary builds and have not been tested yet and are not yet functional.
Include Tenant in Urls.
Tested with entra.microsoftonline.com
Yandex, like X i.e Twitter, uses PKCE with a code_verifier based on the more 'S256' and not 'plain'.
samdark
requested changes
Sep 9, 2025
samdark
requested changes
Sep 10, 2025
Co-authored-by: Alexander Makarov <[email protected]>
Co-authored-by: Alexander Makarov <[email protected]>
Yes be better. |
samdark
requested changes
Sep 11, 2025
|
Please check diff. There are older comments not being addressed as well. |
|
I am trying to get AuthChoice working on my app currently. Picked up one or two anomalies/irregularities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.