Skip to content
This repository was archived by the owner on Mar 26, 2018. It is now read-only.

Conversation

ghost
Copy link

@ghost ghost commented Mar 11, 2013

No description provided.

passy and others added 7 commits February 28, 2013 11:20
The `.editorconfig` set the indent style to 4 spaces, while the `.jshintrc` and templates were using two spaces.
Update editorconfig to use 2 spaces indention
Test runner fix for Windows
Copy .gif, .webp to dist
@ghost
Copy link
Author

ghost commented Mar 14, 2013

@btford what do you think ?

@btford
Copy link
Contributor

btford commented Mar 20, 2013

I think it needs a test. It'd be great if you would write a test that shows this fix works, otherwise I'll get to it before the next release.

@confraria
Copy link

If you just concat the html files won't you loose reference to template path which is essential to $templateCache?

@btford
Copy link
Contributor

btford commented May 6, 2013

@luisbug this isn't concating (as far as I can tell), just minifying.

Unless someone wants to own rebasing and testing this, I'm going to close it. I'm not convinced that this is worth the trouble quite yet, especially in light of the issues htmlmin has with custom tags/attributes.

@ghost
Copy link
Author

ghost commented May 6, 2013

@btford
Can you guide me or show me an example of writing test for this kind of task. I think it's reasonable because we always manage our html files in sub folders instead of putting all of them in the root folder of views .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this being changed?

@sindresorhus
Copy link
Member

@rhacker can you fix the merge conflict and address the comments?

@eddiemonge
Copy link
Member

@rhacker still there?

@btford
Copy link
Contributor

btford commented Jul 18, 2013

This is stale. Closing. Looks like #277 might be a good solution.

@btford btford closed this Jul 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants