Skip to content

Changed handling of dead connections #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Changed handling of dead connections #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver/database_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ def finish_statement_handle(handle)
end

def ensure_established_connection!
raise TinyTds::Error, 'SQL Server client is not connected' if @connection.nil? || [email protected]?
raise TinyTds::Error, 'SQL Server client is not connected' unless @connection

yield
end
Expand Down
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ def initialize_type_map(m = type_map)

def translate_exception(e, message:, sql:, binds:)
case message
when /SQL Server client is not connected/
when /(SQL Server client is not connected) | (failed to execute statement)/i
ConnectionNotEstablished.new(message)
when /(cannot insert duplicate key .* with unique index) | (violation of unique key constraint)/i
RecordNotUnique.new(message, sql: sql, binds: binds)
Expand Down