feat: use meta settings service if configured #3054
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
use-external-settings
branch
3 times, most recently
from
2edf288 to
7603a75
Compare
artemmufazalov
force-pushed
the
use-external-settings
branch
2 times, most recently
from
bf66b22 to
e8d01e2
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
63 files reviewed, 2 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
Comment on lines
81
to
31
| const saveValue = React.useCallback<SaveSettingValue<T>>( | ||
| (value) => { | ||
| if (shouldUseMetaSettings) { | ||
| debouncedSetMetaSetting({ | ||
| user, | ||
| name: name, | ||
| value: stringifySettingValue(value), | ||
| }); | ||
| } | ||
|
|
||
| if (!shouldUseOnlyExternalSettings) { | ||
| setSettingValueToLS(name, value); | ||
| } | ||
| // if (shouldUseMetaSettings) { | ||
| debouncedSetMetaSetting({ | ||
| user, | ||
| name: name, | ||
| value: value as SettingValue, | ||
| }); | ||
| // } | ||
|
|
||
| // if (!shouldUseOnlyExternalSettings) { | ||
| // setSettingValueToLS(name, value); | ||
| // } | ||
| }, | ||
| [shouldUseMetaSettings, shouldUseOnlyExternalSettings, user, name, debouncedSetMetaSetting], | ||
| ); |
Contributor
There was a problem hiding this comment.
logic: saveValue callback always calls debouncedSetMetaSetting even when meta settings aren't enabled, wasting API calls. Check shouldUseMetaSettings before calling.
Suggested change
| const saveValue = React.useCallback<SaveSettingValue<T>>( | |
| (value) => { | |
| if (shouldUseMetaSettings) { | |
| debouncedSetMetaSetting({ | |
| user, | |
| name: name, | |
| value: stringifySettingValue(value), | |
| }); | |
| } | |
| if (!shouldUseOnlyExternalSettings) { | |
| setSettingValueToLS(name, value); | |
| } | |
| // if (shouldUseMetaSettings) { | |
| debouncedSetMetaSetting({ | |
| user, | |
| name: name, | |
| value: value as SettingValue, | |
| }); | |
| // } | |
| // if (!shouldUseOnlyExternalSettings) { | |
| // setSettingValueToLS(name, value); | |
| // } | |
| }, | |
| [shouldUseMetaSettings, shouldUseOnlyExternalSettings, user, name, debouncedSetMetaSetting], | |
| ); | |
| const saveValue = React.useCallback<SaveSettingValue<T>>( | |
| (value) => { | |
| if (shouldUseMetaSettings) { | |
| debouncedSetMetaSetting({ | |
| user, | |
| name: name, | |
| value: value as SettingValue, | |
| }); | |
| } | |
| // if (!shouldUseOnlyExternalSettings) { | |
| // setSettingValueToLS(name, value); | |
| // } | |
| }, | |
| [shouldUseMetaSettings, shouldUseOnlyExternalSettings, user, name, debouncedSetMetaSetting], | |
| ); |
|
|
||
| const {currentData: metaSetting, isLoading: isSettingLoading} = | ||
| settingsApi.useGetSingleSettingQuery(params); | ||
| const {isLoading: isSettingLoading} = settingsApi.useGetSingleSettingQuery({user, name}); |
Contributor
There was a problem hiding this comment.
logic: useGetSingleSettingQuery is called unconditionally even when user or name are undefined, causing unnecessary API calls. The query should be skipped using skipToken when these are missing.
Suggested change
| const {isLoading: isSettingLoading} = settingsApi.useGetSingleSettingQuery({user, name}); | |
| const {isLoading: isSettingLoading} = settingsApi.useGetSingleSettingQuery(shouldUseMetaSettings ? {user, name} : skipToken); |
artemmufazalov
force-pushed
the
use-external-settings
branch
from
7455ef9 to
0f4d528
Compare
artemmufazalov
force-pushed
the
use-external-settings
branch
from
0f4d528 to
5306359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2892
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 66.14 MB | Main: 66.13 MB
Diff: +0.01 MB (0.02%)
ℹ️ CI Information
Issues Found
useSettinghook has multiple React dependency issues causing stale closures and missed updatesMetaSettingsAPI.flushBatch()when batch is emptydelete localStorage[name]instead of properlocalStorage.removeItem()methodArchitecture
The implementation uses a layered approach: UI components call
useSettinghook → hook manages Redux state + localStorage + meta API calls →MetaSettingsAPIbatches requests → backend stores settings. Settings can be configured to sync with localStorage or only use external storage viaSETTINGS_OPTIONS.Confidence Score: 2/5
useSettinghook has multiple missing dependencies in useEffect hooks that will cause stale closures and missed updates. The empty dependency array on line 82 means the sync effect never re-runs when dependencies change. The debounced function memo is missingsetMetaSettingcausing it to capture stale references. The cleanup effect is also missing its dependency. Additionally, there's a timeout leak in the batch flushing logic. These are logical errors that will cause settings to not sync properly between localStorage and the backend, potentially losing user data.src/store/reducers/settings/useSetting.ts- it has multiple critical dependency issues that must be fixed before mergingImportant Files Changed
File Analysis
Sequence Diagram
sequenceDiagram participant User participant Component participant useSetting participant Redux participant LocalStorage participant MetaSettingsAPI participant YDB User->>Component: Interact with UI Component->>useSetting: Call useSetting(name) alt useMetaSettings enabled useSetting->>Redux: Get user/id from auth state useSetting->>MetaSettingsAPI: getSingleSetting({name, user}) alt Request batching MetaSettingsAPI->>MetaSettingsAPI: Add to requestQueue MetaSettingsAPI->>MetaSettingsAPI: setTimeout(100ms) MetaSettingsAPI->>YDB: Batch getSettings({user, name[]}) YDB-->>MetaSettingsAPI: Return settings map MetaSettingsAPI-->>useSetting: Resolve batched requests end useSetting->>LocalStorage: Read initial value (if sync enabled) useSetting->>Redux: setSettingValue(name, value) alt Meta setting exists useSetting->>LocalStorage: Sync from backend (if enabled) useSetting->>Redux: Update with backend value else Meta setting empty AND localStorage has value useSetting->>MetaSettingsAPI: Upload localStorage value useSetting->>LocalStorage: Delete from LS (if preventSyncWithLS) end else useMetaSettings disabled useSetting->>LocalStorage: Read value useSetting->>Redux: setSettingValue(name, value) end useSetting-->>Component: Return {value, saveValue, isLoading} User->>Component: Change setting Component->>useSetting: Call saveValue(newValue) alt useMetaSettings enabled useSetting->>MetaSettingsAPI: setSingleSetting (debounced) MetaSettingsAPI->>YDB: POST /meta/user_settings YDB-->>MetaSettingsAPI: Success response MetaSettingsAPI->>Redux: Update cache optimistically end useSetting->>LocalStorage: Save value (if sync enabled) useSetting->>Redux: Update stateGreptile Summary
preventSyncWithLSflagConfidence Score: 2/5
useSettinghook has stale closure issues due to missingsetMetaSettingin the debounced function's useMemo dependencies and incorrect dependencies in thesaveValuecallback, causing settings to not sync properly between localStorage and backend.src/store/reducers/settings/useSetting.ts- it has critical dependency issues that must be fixed before merging.Important Files Changed
setMetaSettingdependency in debounced function memo and incorrect deps in saveValue callbackSequence Diagram
sequenceDiagram participant User participant Component participant useSetting participant Redux participant LocalStorage participant MetaSettingsAPI participant YDB User->>Component: "Interact with UI" Component->>useSetting: "Call useSetting(name)" alt useMetaSettings enabled useSetting->>Redux: "Get user/id from auth state" useSetting->>MetaSettingsAPI: "getSingleSetting({name, user})" alt Request batching MetaSettingsAPI->>MetaSettingsAPI: "Add to requestQueue" MetaSettingsAPI->>MetaSettingsAPI: "setTimeout(100ms)" MetaSettingsAPI->>YDB: "Batch getSettings({user, name[]})" YDB-->>MetaSettingsAPI: "Return settings map" MetaSettingsAPI-->>useSetting: "Resolve batched requests" end useSetting->>LocalStorage: "Read initial value (if sync enabled)" useSetting->>Redux: "setSettingValue(name, value)" alt Meta setting exists useSetting->>LocalStorage: "Sync from backend (if enabled)" useSetting->>Redux: "Update with backend value" else Meta setting empty AND localStorage has value useSetting->>MetaSettingsAPI: "Upload localStorage value" useSetting->>LocalStorage: "Delete from LS (if preventSyncWithLS)" end else useMetaSettings disabled useSetting->>LocalStorage: "Read value" useSetting->>Redux: "setSettingValue(name, value)" end useSetting-->>Component: "Return {value, saveValue, isLoading}" User->>Component: "Change setting" Component->>useSetting: "Call saveValue(newValue)" alt useMetaSettings enabled useSetting->>MetaSettingsAPI: "setSingleSetting (debounced)" MetaSettingsAPI->>YDB: "POST /meta/user_settings" YDB-->>MetaSettingsAPI: "Success response" MetaSettingsAPI->>Redux: "Update cache optimistically" end useSetting->>LocalStorage: "Save value (if sync enabled)" useSetting->>Redux: "Update state"