Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #3724
When running
yarn installwith a customized--modules-folder, binaries are still linked under the defaultnode_modules/.bin.This PR fixes that behavior.
From now on:
installandaddcommands will link binaries undercustom/.bin.runcommand will prepend the custom folder path toPATHenv.removecommand will remove the specified package from the custom folder. The same wayinstall --forcewill prune extraneous from custom folder.Test plan
All the following were tested with local
.yarnrctoo.Add
$ yarn --modules-folder custom add acorn $ tree -a --noreport custom/.bin/ custom/.bin/ └── acorn -> ../acorn/bin/acornInstall
$ cat package.json { "dependencies": { "acorn": "^5.7.1" } } $ yarn --modules-folder custom install $ tree -a --noreport custom/.bin/ custom/.bin/ └── acorn -> ../acorn/bin/acornRun
$ cat package.json { "scripts": { "start": "acorn --help" }, "dependencies": { "acorn": "^5.7.1" } } $ yarn --modules-folder custom start $ acorn --help usage: acorn [--ecma3|--ecma5|--ecma6|--ecma7|--ecma8|--ecma9|...|--ecma2015|--ecma2016|--ecma2017|--ecma2018|...] [--tokenize] [--locations] [---allow-hash-bang] [--compact] [--silent] [--module] [--help] [--] [infile] Done in 0.26s.Remove