Fix OIDC publishing for scoped packages #6911
Merged
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
While we're at it is it possible to add tests for the feature though a mock endpoint? |
Contributor
Author
|
Yes, a simple mock test can be added for confirmed behavior. But we need to check it e2e first. |
cometkim
added a commit
to cometkim/npgi
that referenced
this pull request
Sep 19, 2025
sources from yarnpkg/berry#6911
Contributor
Author
|
testing now.. |
Contributor
Author
|
publishing work confirmed here: |
Contributor
Author
|
@arcanis Can we release the patch before more people experience the issue? I can't add the test files right now. Or I'll add it maybe tomorrow. |
|
Can we get this PR released? This is blocking the publish pipeline of SWC**** |
Member
|
Release in progress 🚋 🚋 🚋 |
Member
|
4.10.3 is available |
|
Thank you! |
cometkim
added a commit
to rescript-lang/rescript
that referenced
this pull request
Sep 23, 2025
cknitt
pushed a commit
to rescript-lang/rescript
that referenced
this pull request
Sep 26, 2025
cometkim
added a commit
to rescript-lang/rescript
that referenced
this pull request
Sep 26, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
At #6898, I made a mistake, making it not work for scoped packages.