Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.
This repository was archived by the owner on May 1, 2020. It is now read-only.

threshold percentage value seems to be getting ignored #46

@sjethvani

Description

@sjethvani

I am comparing two images and passing parameters like '--threshold-type' percent & '--threshold' somevalue to Pass/Fail comparison on base of threshold .
However it seems threshold value is not getting honored

D:\>node d:\node_modules\blink-diff\bin\blink-diff --verbose --threshold-
type percent --threshold 0.001% --output compare1.png previous_release1.png next_release1.png
Blink-Diff 1.0.13
Copyright (C) 2014 Yahoo! Inc.
Images are similar
386 pixels are different
Wrote differences to compare1.png
Time: 833.052ms
Differences: 386 (0.05%)
PASS

However when I pass threshold as 0% (--threshold 0%) , it works as expected and FAILs comparison when difference is > 0%.

D:\>node d:\node_modules\blink-diff\bin\blink-diff --verbose --threshold-
type percent --threshold 0% --output compare1.png previous_release1.png next_release1.png
Blink-Diff 1.0.13
Copyright (C) 2014 Yahoo! Inc.
Images are visibly different
386 pixels are different
Wrote differences to compare1.png
Time: 846.282ms
Differences: 386 (0.05%)
FAIL

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions