Skip to content

Add typing to tests #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Add typing to tests #168

wants to merge 36 commits into from

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Oct 9, 2022 •
edited
Loading

Add typing to tests to further improve test coverage.

  • Mypy didn't run on the tests. Moved them to \flox.
  • Fixtures are supposed to go in the conftest.py. Moved them there.

xref:
pydata/xarray#6730

@Illviljan Illviljan marked this pull request as ready for review October 9, 2022 22:39
dcherian
dcherian reviewed Oct 11, 2022
View reviewed changes
dcherian
dcherian reviewed Oct 11, 2022
View reviewed changes
dcherian
dcherian reviewed Oct 11, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Illviljan @dcherian