allow DataTree objects as root node in from_dict
#221
Conversation
TomNicholas
left a comment
TomNicholas
left a comment
There was a problem hiding this comment.
Thanks @keewis ! I have one comment about possible unintended behavior here.
| if not isinstance(root_data, cls): | ||
| obj = cls(name=name, data=root_data, parent=None, children=None) | ||
| else: | ||
| obj = root_data.copy() |
There was a problem hiding this comment.
I think there is potential for bugs here - .copy() will copy child nodes too, so if root_data has children already they will presumably be copied into the new tree. You could also then double-specify the contents of a single node, once as the child of the root and again in the supplied dict.
In fact your previous PR might do this too - I think we should decide what we want the behavior to be: either drop all children of supplied nodes or explicitly test that we keep children too.
If we do want to drop the children it would probably be clearer to just create a new node using a copy of the supplied node's name and data.
There was a problem hiding this comment.
this is a bit similar to what xarray does already when passing DataArray objects with coordinates to the Dataset constructor / Dataset.assign*: those coordinates will be carried over (unintentionally overriding coordinates explicitly passed in the same call).
I'm not sure if we need to copy the behavior, though.
I didn't have a need for it ever since opening this PR, so this is also pretty low-priority for me (as you might have guessed from the long delay)
|
looks like this has been fixed while migrating into |
2 participants
DataTreeobjects as values infrom_dict#159pre-commit run --all-filesdocs/source/whats-new.rst