This repository was archived by the owner on Oct 24, 2024. It is now read-only.
move to a pyproject.toml-based build configuration
#219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keewis
changed the title
pyproject.toml-based configurationpyproject.toml-based build configuration
Member
|
Amazing thank you @keewis ! Merge this whenever you feel like it's ready! |
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
…atatree#219 * move to a `pyproject.toml`-based configuration * move the `flake8` configuration to a separate file * move `isort` and `mypy` configuration to `pyproject.toml` * update the `isort` version to avoid the install error * install the currently checked-out version of datatree [skip-ci] * install xarray from conda-forge * fix the install path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what the reason for the failure is, but moving the project metadata to
pyproject.tomlside-steps the issue entirely (plus, we would have to do the migration some time soon anyways).In the process I also upgraded the minimum requirement for
setuptools_scmto>=7.0, which gets rid of thesetuptools_scm_git_archiveplugin (because that's now included in the main package).I've read somewhere that having
setup.*together withpyproject.tomlis not great becausepipgets confused, but I don't know what issue exactly that was referring to. In any case, we can moveisortandmypyconfiguration topyproject.toml, as well, andflake8can be moved to.flake8, which allows us to entirely removesetup.cfg.Since
xarrayrecently moved toruffwe might want to follow here, but I'd say let's do that in a separate PR.pre-commit run --all-filesdocs/source/whats-new.rst