This repository was archived by the owner on Oct 24, 2024. It is now read-only.
Explicit copy #171
Merged
Explicit copy #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2022
3 tasks
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* added descendants property * tests for descendants, lineage, ancestors, subtree * added descendants to API docs * whatsnew * rerun tests * rewrote copy method * remove outdated mypy ignore error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of copying the
copymethod fromDatasetand mapping it over all nodes, this PR explicitly writes out thecopymethod onDataTree, but also changes it to only copy the subtree, and not the parents.Builds upon #170.
DataTreeobjects as values infrom_dict#159 (comment)Tests addedpre-commit run --all-filesNew functions/methods are listed inapi.rstdocs/source/whats-new.rst