Skip to content
This repository was archived by the owner on Mar 8, 2021. It is now read-only.

Conversation

@atsushieno
Copy link
Contributor

No description provided.

@atsushieno
Copy link
Contributor Author

The diff is quite useless. Here is the results from make run-api-compatibility-tests without changes in this PR AND changes in dotnet/android#1821:

<h1>Mono.Android.dll</h1>
<div data-is-topmost>
<!-- start namespace Android.App --> <div> 
<h2>Namespace Android.App</h2>
<!-- start type Importance --> <div>
<h3>Type Changed: Android.App.Importance</h3>
<p>Modified fields:</p>
<pre>
<div data-is-breaking>	TopSleeping = <span class='removed removed-inline removed-breaking-inline'>150</span> <span class='added '>325</span>
</div></pre>

</div> <!-- end type Importance -->

</div> <!-- end namespace Android.App -->
<!-- start namespace Android.Telephony --> <div> 
<h2>Namespace Android.Telephony</h2>
<!-- start type CellIdentityCdma --> <div>
<h3>Type Changed: Android.Telephony.CellIdentityCdma</h3>
Modified base type: <span class='removed removed-inline removed-breaking-inline'>Java.Lang.Object</span> <span class='added '>Android.Telephony.CellIdentity</span>
<h3>Removed Type <span class='breaking' data-is-breaking>Android.Telephony.CellIdentityCdma.InterfaceConsts</span></h3>
</div> <!-- end type CellIdentityCdma -->
<!-- start type CellIdentityGsm --> <div>
<h3>Type Changed: Android.Telephony.CellIdentityGsm</h3>
Modified base type: <span class='removed removed-inline removed-breaking-inline'>Java.Lang.Object</span> <span class='added '>Android.Telephony.CellIdentity</span>
<h3>Removed Type <span class='breaking' data-is-breaking>Android.Telephony.CellIdentityGsm.InterfaceConsts</span></h3>
</div> <!-- end type CellIdentityGsm -->
<!-- start type CellIdentityLte --> <div>
<h3>Type Changed: Android.Telephony.CellIdentityLte</h3>
Modified base type: <span class='removed removed-inline removed-breaking-inline'>Java.Lang.Object</span> <span class='added '>Android.Telephony.CellIdentity</span>
<h3>Removed Type <span class='breaking' data-is-breaking>Android.Telephony.CellIdentityLte.InterfaceConsts</span></h3>
</div> <!-- end type CellIdentityLte -->
<!-- start type CellIdentityWcdma --> <div>
<h3>Type Changed: Android.Telephony.CellIdentityWcdma</h3>
Modified base type: <span class='removed removed-inline removed-breaking-inline'>Java.Lang.Object</span> <span class='added '>Android.Telephony.CellIdentity</span>
<h3>Removed Type <span class='breaking' data-is-breaking>Android.Telephony.CellIdentityWcdma.InterfaceConsts</span></h3>
</div> <!-- end type CellIdentityWcdma -->

</div> <!-- end namespace Android.Telephony -->
</div> <!-- end topmost div -->
</div>
Makefile:94: recipe for target 'check' failed
make[1]: *** [check] Error 1
make[1]: Leaving directory '/sources/xamarin-android/external/xamarin-android-api-compatibility'
tests/api-compatibility/api-compatibility.mk:16: recipe for target 'run-api-compatibility-tests' failed
make: *** [run-api-compatibility-tests] Error 2

@atsushieno
Copy link
Contributor Author

The changes shown here are 1) removed InterfaceConsts types and 2) constant value update. 1) is harmless and 2) is inevitable as long as Google changes the value (should not break ABI anyways).

@jonpryor
Copy link
Contributor

What's kinda odd is that the API Compatibility Checks in the PR build you linked to don't list the base class changes, just the change to TopSleeping.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants